Avoid NPE on FinatraInstrumentation #9760

amarziali · 2025-10-15T07:57:33Z

What Does This Do

Avoid throwing NPE on accessing potential parent null span in finatra instrumentation

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-10-15T08:17:47Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 71.89% (+12.09%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: b1269ef | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-15T08:32:22Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/finatra
git_commit_date	1760513926	1760514840
git_commit_sha	`d131c9d`	`b1269ef`
release_version	1.55.0-SNAPSHOT~d131c9d4a9	1.55.0-SNAPSHOT~b1269ef5b5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1760516895	1760516895
ci_job_id	1179639240	1179639240
ci_pipeline_id	79330300	79330300
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-wq3ik8cb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-wq3ik8cb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 3 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016505
Total [baseline] (8.676 s) : 0, 8676335
Agent [candidate] (1.035 s) : 0, 1035074
Total [candidate] (8.782 s) : 0, 8781685
section iast
Agent [baseline] (1.151 s) : 0, 1150675
Total [baseline] (9.326 s) : 0, 9325815
Agent [candidate] (1.153 s) : 0, 1152693
Total [candidate] (9.282 s) : 0, 9281529

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.017 s	-
Agent	iast	1.151 s	134.171 ms (13.2%)
Total	tracing	8.676 s	-
Total	iast	9.326 s	649.48 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.035 s	-
Agent	iast	1.153 s	117.619 ms (11.4%)
Total	tracing	8.782 s	-
Total	iast	9.282 s	499.844 ms (5.7%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (693.623 ms) : 0, 693623
BytebuddyAgent [candidate] (705.818 ms) : 0, 705818
GlobalTracer [baseline] (241.664 ms) : 0, 241664
GlobalTracer [candidate] (245.588 ms) : 0, 245588
AppSec [baseline] (32.423 ms) : 0, 32423
AppSec [candidate] (32.914 ms) : 0, 32914
Debugger [baseline] (6.413 ms) : 0, 6413
Debugger [candidate] (6.574 ms) : 0, 6574
Remote Config [baseline] (709.56 µs) : 0, 710
Remote Config [candidate] (709.845 µs) : 0, 710
Telemetry [baseline] (9.341 ms) : 0, 9341
Telemetry [candidate] (9.47 ms) : 0, 9470
Flare Poller [baseline] (9.608 ms) : 0, 9608
Flare Poller [candidate] (10.986 ms) : 0, 10986
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.5 ms) : 0, 1500
BytebuddyAgent [baseline] (815.054 ms) : 0, 815054
BytebuddyAgent [candidate] (816.584 ms) : 0, 816584
GlobalTracer [baseline] (231.184 ms) : 0, 231184
GlobalTracer [candidate] (231.558 ms) : 0, 231558
IAST [baseline] (26.507 ms) : 0, 26507
IAST [candidate] (26.447 ms) : 0, 26447
AppSec [baseline] (35.343 ms) : 0, 35343
AppSec [candidate] (35.361 ms) : 0, 35361
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (606.719 µs) : 0, 607
Remote Config [candidate] (609.749 µs) : 0, 610
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (8.701 ms) : 0, 8701
Flare Poller [baseline] (4.268 ms) : 0, 4268
Flare Poller [candidate] (4.249 ms) : 0, 4249

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016468
Total [baseline] (10.713 s) : 0, 10713046
Agent [candidate] (1.016 s) : 0, 1016338
Total [candidate] (10.697 s) : 0, 10697061
section appsec
Agent [baseline] (1.193 s) : 0, 1193194
Total [baseline] (11.062 s) : 0, 11062126
Agent [candidate] (1.194 s) : 0, 1193630
Total [candidate] (11.097 s) : 0, 11096504
section iast
Agent [baseline] (1.151 s) : 0, 1150636
Total [baseline] (11.029 s) : 0, 11029158
Agent [candidate] (1.151 s) : 0, 1150707
Total [candidate] (11.068 s) : 0, 11067589
section profiling
Agent [baseline] (1.162 s) : 0, 1162067
Total [baseline] (11.051 s) : 0, 11050805
Agent [candidate] (1.162 s) : 0, 1161531
Total [candidate] (11.081 s) : 0, 11081338

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.016 s	-
Agent	appsec	1.193 s	176.726 ms (17.4%)
Agent	iast	1.151 s	134.168 ms (13.2%)
Agent	profiling	1.162 s	145.599 ms (14.3%)
Total	tracing	10.713 s	-
Total	appsec	11.062 s	349.079 ms (3.3%)
Total	iast	11.029 s	316.112 ms (3.0%)
Total	profiling	11.051 s	337.759 ms (3.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.016 s	-
Agent	appsec	1.194 s	177.292 ms (17.4%)
Agent	iast	1.151 s	134.369 ms (13.2%)
Agent	profiling	1.162 s	145.193 ms (14.3%)
Total	tracing	10.697 s	-
Total	appsec	11.097 s	399.444 ms (3.7%)
Total	iast	11.068 s	370.528 ms (3.5%)
Total	profiling	11.081 s	384.277 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (692.323 ms) : 0, 692323
BytebuddyAgent [candidate] (692.193 ms) : 0, 692193
GlobalTracer [baseline] (241.63 ms) : 0, 241630
GlobalTracer [candidate] (241.612 ms) : 0, 241612
AppSec [baseline] (32.495 ms) : 0, 32495
AppSec [candidate] (32.274 ms) : 0, 32274
Debugger [baseline] (6.427 ms) : 0, 6427
Debugger [candidate] (6.43 ms) : 0, 6430
Remote Config [baseline] (716.958 µs) : 0, 717
Remote Config [candidate] (709.02 µs) : 0, 709
Telemetry [baseline] (9.354 ms) : 0, 9354
Telemetry [candidate] (9.383 ms) : 0, 9383
Flare Poller [baseline] (10.832 ms) : 0, 10832
Flare Poller [candidate] (11.044 ms) : 0, 11044
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (717.46 ms) : 0, 717460
BytebuddyAgent [candidate] (717.721 ms) : 0, 717721
GlobalTracer [baseline] (234.379 ms) : 0, 234379
GlobalTracer [candidate] (234.335 ms) : 0, 234335
IAST [baseline] (24.605 ms) : 0, 24605
IAST [candidate] (24.743 ms) : 0, 24743
AppSec [baseline] (175.136 ms) : 0, 175136
AppSec [candidate] (175.28 ms) : 0, 175280
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.11 ms) : 0, 6110
Remote Config [baseline] (629.797 µs) : 0, 630
Remote Config [candidate] (628.193 µs) : 0, 628
Telemetry [baseline] (8.431 ms) : 0, 8431
Telemetry [candidate] (8.424 ms) : 0, 8424
Flare Poller [baseline] (3.856 ms) : 0, 3856
Flare Poller [candidate] (3.854 ms) : 0, 3854
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (814.942 ms) : 0, 814942
BytebuddyAgent [candidate] (815.312 ms) : 0, 815312
GlobalTracer [baseline] (231.349 ms) : 0, 231349
GlobalTracer [candidate] (231.435 ms) : 0, 231435
IAST [baseline] (26.565 ms) : 0, 26565
IAST [candidate] (26.294 ms) : 0, 26294
AppSec [baseline] (35.113 ms) : 0, 35113
AppSec [candidate] (35.178 ms) : 0, 35178
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.115 ms) : 0, 6115
Remote Config [baseline] (623.222 µs) : 0, 623
Remote Config [candidate] (604.793 µs) : 0, 605
Telemetry [baseline] (8.609 ms) : 0, 8609
Telemetry [candidate] (8.608 ms) : 0, 8608
Flare Poller [baseline] (4.272 ms) : 0, 4272
Flare Poller [candidate] (4.154 ms) : 0, 4154
section profiling
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (720.893 ms) : 0, 720893
BytebuddyAgent [candidate] (720.184 ms) : 0, 720184
GlobalTracer [baseline] (217.984 ms) : 0, 217984
GlobalTracer [candidate] (217.488 ms) : 0, 217488
AppSec [baseline] (32.349 ms) : 0, 32349
AppSec [candidate] (32.521 ms) : 0, 32521
Debugger [baseline] (6.53 ms) : 0, 6530
Debugger [candidate] (6.478 ms) : 0, 6478
Remote Config [baseline] (809.375 µs) : 0, 809
Remote Config [candidate] (746.412 µs) : 0, 746
Telemetry [baseline] (16.252 ms) : 0, 16252
Telemetry [candidate] (16.43 ms) : 0, 16430
Flare Poller [baseline] (4.098 ms) : 0, 4098
Flare Poller [candidate] (4.077 ms) : 0, 4077
ProfilingAgent [baseline] (107.26 ms) : 0, 107260
ProfilingAgent [candidate] (108.584 ms) : 0, 108584
Profiling [baseline] (109.679 ms) : 0, 109679
Profiling [candidate] (110.175 ms) : 0, 110175

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/finatra
git_commit_date	1760513926	1760514840
git_commit_sha	`d131c9d`	`b1269ef`
release_version	1.55.0-SNAPSHOT~d131c9d4a9	1.55.0-SNAPSHOT~b1269ef5b5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1760516556	1760516556
ci_job_id	1179639241	1179639241
ci_pipeline_id	79330300	79330300
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-4-qehf8f3p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-4-qehf8f3p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+251.187µs; +687.097µs] or [+2.284%; +6.248%]	unstable [-65.195op/s; +30.883op/s] or [-15.416%; +7.303%]	11.466ms	405.750op/s	10.997ms	422.906op/s
scenario:load:insecure-bank:iast_FULL:high_load	worse [+597.246µs; +1207.271µs] or [+4.292%; +8.676%]	unstable [-56.745op/s; +16.245op/s] or [-16.945%; +4.851%]	14.817ms	314.625op/s	13.915ms	334.875op/s
scenario:load:petclinic:no_agent:high_load	better [-2.863ms; -2.231ms] or [-7.511%; -5.854%]	unstable [-0.148op/s; +17.723op/s] or [-0.120%; +14.447%]	35.565ms	131.463op/s	38.112ms	122.675op/s
scenario:load:petclinic:code_origins:high_load	better [-2.480ms; -1.654ms] or [-5.444%; -3.631%]	unstable [-1.159op/s; +13.583op/s] or [-1.128%; +13.221%]	43.484ms	108.949op/s	45.551ms	102.737op/s
scenario:load:petclinic:profiling:high_load	better [-3.381ms; -2.382ms] or [-6.751%; -4.755%]	unstable [-0.065op/s; +14.026op/s] or [-0.069%; +15.009%]	47.206ms	100.430op/s	50.088ms	93.450op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.318 ms) : 4269, 4367
.   : milestone, 4318,
iast (9.719 ms) : 9553, 9886
.   : milestone, 9719,
iast_FULL (13.915 ms) : 13637, 14193
.   : milestone, 13915,
iast_GLOBAL (10.997 ms) : 10799, 11195
.   : milestone, 10997,
profiling (9.096 ms) : 8955, 9236
.   : milestone, 9096,
tracing (7.534 ms) : 7421, 7648
.   : milestone, 7534,
section candidate
no_agent (4.37 ms) : 4319, 4420
.   : milestone, 4370,
iast (9.497 ms) : 9328, 9666
.   : milestone, 9497,
iast_FULL (14.817 ms) : 14528, 15106
.   : milestone, 14817,
iast_GLOBAL (11.466 ms) : 11259, 11673
.   : milestone, 11466,
profiling (9.239 ms) : 9074, 9404
.   : milestone, 9239,
tracing (7.384 ms) : 7280, 7487
.   : milestone, 7384,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.318 ms [4.269 ms, 4.367 ms]	-
iast	9.719 ms [9.553 ms, 9.886 ms]	5.401 ms (125.1%)
iast_FULL	13.915 ms [13.637 ms, 14.193 ms]	9.597 ms (222.3%)
iast_GLOBAL	10.997 ms [10.799 ms, 11.195 ms]	6.679 ms (154.7%)
profiling	9.096 ms [8.955 ms, 9.236 ms]	4.778 ms (110.6%)
tracing	7.534 ms [7.421 ms, 7.648 ms]	3.216 ms (74.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.37 ms [4.319 ms, 4.42 ms]	-
iast	9.497 ms [9.328 ms, 9.666 ms]	5.128 ms (117.3%)
iast_FULL	14.817 ms [14.528 ms, 15.106 ms]	10.447 ms (239.1%)
iast_GLOBAL	11.466 ms [11.259 ms, 11.673 ms]	7.096 ms (162.4%)
profiling	9.239 ms [9.074 ms, 9.404 ms]	4.869 ms (111.4%)
tracing	7.384 ms [7.28 ms, 7.487 ms]	3.014 ms (69.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.112 ms) : 37804, 38419
.   : milestone, 38112,
appsec (49.668 ms) : 49234, 50102
.   : milestone, 49668,
code_origins (45.551 ms) : 45157, 45945
.   : milestone, 45551,
iast (45.339 ms) : 44949, 45730
.   : milestone, 45339,
profiling (50.088 ms) : 49598, 50577
.   : milestone, 50088,
tracing (46.621 ms) : 46228, 47013
.   : milestone, 46621,
section candidate
no_agent (35.565 ms) : 35286, 35844
.   : milestone, 35565,
appsec (49.09 ms) : 48675, 49504
.   : milestone, 49090,
code_origins (43.484 ms) : 43111, 43858
.   : milestone, 43484,
iast (45.11 ms) : 44734, 45486
.   : milestone, 45110,
profiling (47.206 ms) : 46768, 47644
.   : milestone, 47206,
tracing (45.763 ms) : 45363, 46163
.   : milestone, 45763,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.112 ms [37.804 ms, 38.419 ms]	-
appsec	49.668 ms [49.234 ms, 50.102 ms]	11.557 ms (30.3%)
code_origins	45.551 ms [45.157 ms, 45.945 ms]	7.44 ms (19.5%)
iast	45.339 ms [44.949 ms, 45.73 ms]	7.228 ms (19.0%)
profiling	50.088 ms [49.598 ms, 50.577 ms]	11.976 ms (31.4%)
tracing	46.621 ms [46.228 ms, 47.013 ms]	8.509 ms (22.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.565 ms [35.286 ms, 35.844 ms]	-
appsec	49.09 ms [48.675 ms, 49.504 ms]	13.525 ms (38.0%)
code_origins	43.484 ms [43.111 ms, 43.858 ms]	7.92 ms (22.3%)
iast	45.11 ms [44.734 ms, 45.486 ms]	9.545 ms (26.8%)
profiling	47.206 ms [46.768 ms, 47.644 ms]	11.641 ms (32.7%)
tracing	45.763 ms [45.363 ms, 46.163 ms]	10.198 ms (28.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/finatra
git_commit_date	1760513926	1760514840
git_commit_sha	`d131c9d`	`b1269ef`
release_version	1.55.0-SNAPSHOT~d131c9d4a9	1.55.0-SNAPSHOT~b1269ef5b5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1760517059	1760517059
ci_job_id	1179639242	1179639242
ci_pipeline_id	79330300	79330300
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-7s825l8b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-7s825l8b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.701 ms) : 3482, 3920
.   : milestone, 3701,
iast (2.203 ms) : 2140, 2266
.   : milestone, 2203,
iast_GLOBAL (2.253 ms) : 2189, 2317
.   : milestone, 2253,
profiling (2.043 ms) : 1992, 2094
.   : milestone, 2043,
tracing (2.017 ms) : 1968, 2067
.   : milestone, 2017,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.669 ms) : 3456, 3882
.   : milestone, 3669,
iast (2.202 ms) : 2139, 2266
.   : milestone, 2202,
iast_GLOBAL (2.247 ms) : 2183, 2311
.   : milestone, 2247,
profiling (2.064 ms) : 2012, 2117
.   : milestone, 2064,
tracing (2.018 ms) : 1969, 2067
.   : milestone, 2018,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.701 ms [3.482 ms, 3.92 ms]	2.226 ms (150.8%)
iast	2.203 ms [2.14 ms, 2.266 ms]	727.205 µs (49.3%)
iast_GLOBAL	2.253 ms [2.189 ms, 2.317 ms]	777.503 µs (52.7%)
profiling	2.043 ms [1.992 ms, 2.094 ms]	567.199 µs (38.4%)
tracing	2.017 ms [1.968 ms, 2.067 ms]	541.577 µs (36.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.669 ms [3.456 ms, 3.882 ms]	2.194 ms (148.7%)
iast	2.202 ms [2.139 ms, 2.266 ms]	726.7 µs (49.2%)
iast_GLOBAL	2.247 ms [2.183 ms, 2.311 ms]	771.226 µs (52.3%)
profiling	2.064 ms [2.012 ms, 2.117 ms]	588.56 µs (39.9%)
tracing	2.018 ms [1.969 ms, 2.067 ms]	542.443 µs (36.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b1269ef5b5, baseline=1.55.0-SNAPSHOT~d131c9d4a9
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
appsec (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
iast (18.508 s) : 18508000, 18508000
.   : milestone, 18508000,
iast_GLOBAL (18.05 s) : 18050000, 18050000
.   : milestone, 18050000,
profiling (15.498 s) : 15498000, 15498000
.   : milestone, 15498000,
tracing (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
section candidate
no_agent (15.087 s) : 15087000, 15087000
.   : milestone, 15087000,
appsec (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
iast (18.471 s) : 18471000, 18471000
.   : milestone, 18471000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
.   : milestone, 17979000,
profiling (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
tracing (15.074 s) : 15074000, 15074000
.   : milestone, 15074000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.948 s [14.948 s, 14.948 s]	-
appsec	15.221 s [15.221 s, 15.221 s]	273.0 ms (1.8%)
iast	18.508 s [18.508 s, 18.508 s]	3.56 s (23.8%)
iast_GLOBAL	18.05 s [18.05 s, 18.05 s]	3.102 s (20.8%)
profiling	15.498 s [15.498 s, 15.498 s]	550.0 ms (3.7%)
tracing	14.985 s [14.985 s, 14.985 s]	37.0 ms (0.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.087 s [15.087 s, 15.087 s]	-
appsec	15.014 s [15.014 s, 15.014 s]	-73.0 ms (-0.5%)
iast	18.471 s [18.471 s, 18.471 s]	3.384 s (22.4%)
iast_GLOBAL	17.979 s [17.979 s, 17.979 s]	2.892 s (19.2%)
profiling	14.987 s [14.987 s, 14.987 s]	-100.0 ms (-0.7%)
tracing	15.074 s [15.074 s, 15.074 s]	-13.0 ms (-0.1%)

Avoid NPE on FinatraInstrumentation

b1269ef

amarziali requested a review from a team as a code owner October 15, 2025 07:57

amarziali added type: bug Bug report and fix inst: others All other instrumentations labels Oct 15, 2025

amarziali enabled auto-merge (squash) October 15, 2025 07:59

bric3 approved these changes Oct 15, 2025

View reviewed changes

amarziali merged commit 0d52555 into master Oct 15, 2025
536 checks passed

amarziali deleted the andrea.marziali/finatra branch October 15, 2025 08:36

github-actions bot added this to the 1.55.0 milestone Oct 15, 2025

amarziali added the tag: telemetry-error-reported Reported by error telemetry label Oct 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid NPE on FinatraInstrumentation #9760

Avoid NPE on FinatraInstrumentation #9760

Uh oh!

amarziali commented Oct 15, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 15, 2025

Uh oh!

pr-commenter bot commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Avoid NPE on FinatraInstrumentation #9760

Avoid NPE on FinatraInstrumentation #9760

Uh oh!

Conversation

amarziali commented Oct 15, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 15, 2025

Uh oh!

pr-commenter bot commented Oct 15, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants