-
Notifications
You must be signed in to change notification settings - Fork 314
Improves log injection smoke test laziness #9764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…replaced libsDirectory by layout.buildDirectory
|
🎯 Code Coverage 🔗 Commit SHA: 70ae84f | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017049
Total [baseline] (10.669 s) : 0, 10669177
Agent [candidate] (1.018 s) : 0, 1018165
Total [candidate] (10.732 s) : 0, 10732330
section appsec
Agent [baseline] (1.195 s) : 0, 1194933
Total [baseline] (11.104 s) : 0, 11104209
Agent [candidate] (1.195 s) : 0, 1195411
Total [candidate] (11.059 s) : 0, 11058827
section iast
Agent [baseline] (1.16 s) : 0, 1160189
Total [baseline] (10.994 s) : 0, 10993894
Agent [candidate] (1.168 s) : 0, 1167897
Total [candidate] (11.157 s) : 0, 11156963
section profiling
Agent [baseline] (1.163 s) : 0, 1162826
Total [baseline] (10.989 s) : 0, 10988625
Agent [candidate] (1.159 s) : 0, 1158604
Total [candidate] (11.121 s) : 0, 11120520
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (693.808 ms) : 0, 693808
BytebuddyAgent [candidate] (692.783 ms) : 0, 692783
GlobalTracer [baseline] (242.259 ms) : 0, 242259
GlobalTracer [candidate] (242.144 ms) : 0, 242144
AppSec [baseline] (32.192 ms) : 0, 32192
AppSec [candidate] (32.216 ms) : 0, 32216
Debugger [baseline] (6.447 ms) : 0, 6447
Debugger [candidate] (6.392 ms) : 0, 6392
Remote Config [baseline] (710.491 µs) : 0, 710
Remote Config [candidate] (702.971 µs) : 0, 703
Telemetry [baseline] (9.36 ms) : 0, 9360
Telemetry [candidate] (9.414 ms) : 0, 9414
Flare Poller [baseline] (9.665 ms) : 0, 9665
Flare Poller [candidate] (11.973 ms) : 0, 11973
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (718.307 ms) : 0, 718307
BytebuddyAgent [candidate] (718.988 ms) : 0, 718988
GlobalTracer [baseline] (234.456 ms) : 0, 234456
GlobalTracer [candidate] (234.758 ms) : 0, 234758
IAST [baseline] (24.828 ms) : 0, 24828
IAST [candidate] (24.8 ms) : 0, 24800
AppSec [baseline] (175.748 ms) : 0, 175748
AppSec [candidate] (175.224 ms) : 0, 175224
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.144 ms) : 0, 6144
Remote Config [baseline] (628.83 µs) : 0, 629
Remote Config [candidate] (625.945 µs) : 0, 626
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.907 ms) : 0, 3907
Flare Poller [candidate] (3.918 ms) : 0, 3918
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (822.05 ms) : 0, 822050
BytebuddyAgent [candidate] (827.634 ms) : 0, 827634
GlobalTracer [baseline] (232.908 ms) : 0, 232908
GlobalTracer [candidate] (234.424 ms) : 0, 234424
IAST [baseline] (26.754 ms) : 0, 26754
IAST [candidate] (27.012 ms) : 0, 27012
AppSec [baseline] (35.416 ms) : 0, 35416
AppSec [candidate] (35.508 ms) : 0, 35508
Debugger [baseline] (6.224 ms) : 0, 6224
Debugger [candidate] (6.258 ms) : 0, 6258
Remote Config [baseline] (630.802 µs) : 0, 631
Remote Config [candidate] (633.286 µs) : 0, 633
Telemetry [baseline] (8.828 ms) : 0, 8828
Telemetry [candidate] (8.845 ms) : 0, 8845
Flare Poller [baseline] (4.272 ms) : 0, 4272
Flare Poller [candidate] (4.355 ms) : 0, 4355
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (721.494 ms) : 0, 721494
BytebuddyAgent [candidate] (719.088 ms) : 0, 719088
GlobalTracer [baseline] (217.478 ms) : 0, 217478
GlobalTracer [candidate] (217.177 ms) : 0, 217177
AppSec [baseline] (32.494 ms) : 0, 32494
AppSec [candidate] (32.271 ms) : 0, 32271
Debugger [baseline] (6.462 ms) : 0, 6462
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (749.548 µs) : 0, 750
Remote Config [candidate] (1.626 ms) : 0, 1626
Telemetry [baseline] (16.363 ms) : 0, 16363
Telemetry [candidate] (14.667 ms) : 0, 14667
Flare Poller [baseline] (4.204 ms) : 0, 4204
Flare Poller [candidate] (4.975 ms) : 0, 4975
ProfilingAgent [baseline] (108.814 ms) : 0, 108814
ProfilingAgent [candidate] (107.42 ms) : 0, 107420
Profiling [baseline] (110.05 ms) : 0, 110050
Profiling [candidate] (108.743 ms) : 0, 108743
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020022
Total [baseline] (8.769 s) : 0, 8769197
Agent [candidate] (1.015 s) : 0, 1015403
Total [candidate] (8.693 s) : 0, 8692875
section iast
Agent [baseline] (1.152 s) : 0, 1152013
Total [baseline] (9.325 s) : 0, 9324583
Agent [candidate] (1.15 s) : 0, 1150371
Total [candidate] (9.287 s) : 0, 9287492
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (693.788 ms) : 0, 693788
BytebuddyAgent [candidate] (692.342 ms) : 0, 692342
GlobalTracer [baseline] (242.758 ms) : 0, 242758
GlobalTracer [candidate] (241.909 ms) : 0, 241909
AppSec [baseline] (32.472 ms) : 0, 32472
AppSec [candidate] (32.558 ms) : 0, 32558
Debugger [baseline] (6.472 ms) : 0, 6472
Debugger [candidate] (6.41 ms) : 0, 6410
Remote Config [baseline] (700.195 µs) : 0, 700
Remote Config [candidate] (700.664 µs) : 0, 701
Telemetry [baseline] (9.406 ms) : 0, 9406
Telemetry [candidate] (9.38 ms) : 0, 9380
Flare Poller [baseline] (11.799 ms) : 0, 11799
Flare Poller [candidate] (9.456 ms) : 0, 9456
section iast
crashtracking [baseline] (1.505 ms) : 0, 1505
crashtracking [candidate] (1.496 ms) : 0, 1496
BytebuddyAgent [baseline] (816.251 ms) : 0, 816251
BytebuddyAgent [candidate] (815.061 ms) : 0, 815061
GlobalTracer [baseline] (231.467 ms) : 0, 231467
GlobalTracer [candidate] (231.167 ms) : 0, 231167
IAST [baseline] (26.528 ms) : 0, 26528
IAST [candidate] (26.397 ms) : 0, 26397
AppSec [baseline] (34.956 ms) : 0, 34956
AppSec [candidate] (35.077 ms) : 0, 35077
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (620.285 µs) : 0, 620
Remote Config [candidate] (619.167 µs) : 0, 619
Telemetry [baseline] (8.755 ms) : 0, 8755
Telemetry [candidate] (8.631 ms) : 0, 8631
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.278 ms) : 0, 4278
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (38.917 ms) : 38607, 39228
. : milestone, 38917,
appsec (47.675 ms) : 47251, 48099
. : milestone, 47675,
code_origins (44.332 ms) : 43943, 44720
. : milestone, 44332,
iast (46.016 ms) : 45622, 46410
. : milestone, 46016,
profiling (49.631 ms) : 49141, 50121
. : milestone, 49631,
tracing (46.887 ms) : 46477, 47298
. : milestone, 46887,
section candidate
no_agent (37.238 ms) : 36933, 37544
. : milestone, 37238,
appsec (49.176 ms) : 48751, 49602
. : milestone, 49176,
code_origins (44.285 ms) : 43900, 44669
. : milestone, 44285,
iast (45.266 ms) : 44880, 45652
. : milestone, 45266,
profiling (48.85 ms) : 48369, 49330
. : milestone, 48850,
tracing (43.695 ms) : 43313, 44078
. : milestone, 43695,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (4.416 ms) : 4360, 4471
. : milestone, 4416,
iast (9.806 ms) : 9644, 9968
. : milestone, 9806,
iast_FULL (13.867 ms) : 13591, 14143
. : milestone, 13867,
iast_GLOBAL (10.731 ms) : 10542, 10920
. : milestone, 10731,
profiling (8.835 ms) : 8690, 8980
. : milestone, 8835,
tracing (8.051 ms) : 7935, 8167
. : milestone, 8051,
section candidate
no_agent (4.499 ms) : 4448, 4551
. : milestone, 4499,
iast (10.167 ms) : 9987, 10346
. : milestone, 10167,
iast_FULL (14.807 ms) : 14515, 15098
. : milestone, 14807,
iast_GLOBAL (10.159 ms) : 9969, 10349
. : milestone, 10159,
profiling (8.477 ms) : 8349, 8606
. : milestone, 8477,
tracing (7.759 ms) : 7648, 7870
. : milestone, 7759,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (3.688 ms) : 3473, 3903
. : milestone, 3688,
iast (2.22 ms) : 2156, 2284
. : milestone, 2220,
iast_GLOBAL (2.276 ms) : 2211, 2341
. : milestone, 2276,
profiling (2.091 ms) : 2038, 2145
. : milestone, 2091,
tracing (2.034 ms) : 1984, 2083
. : milestone, 2034,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.759 ms) : 3540, 3977
. : milestone, 3759,
iast (2.231 ms) : 2167, 2296
. : milestone, 2231,
iast_GLOBAL (2.273 ms) : 2209, 2337
. : milestone, 2273,
profiling (2.068 ms) : 2017, 2120
. : milestone, 2068,
tracing (2.047 ms) : 1997, 2096
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~70ae84f14e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
appsec (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
iast (18.76 s) : 18760000, 18760000
. : milestone, 18760000,
iast_GLOBAL (18.244 s) : 18244000, 18244000
. : milestone, 18244000,
profiling (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
tracing (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
section candidate
no_agent (15.305 s) : 15305000, 15305000
. : milestone, 15305000,
appsec (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
iast (18.789 s) : 18789000, 18789000
. : milestone, 18789000,
iast_GLOBAL (18.042 s) : 18042000, 18042000
. : milestone, 18042000,
profiling (15.781 s) : 15781000, 15781000
. : milestone, 15781000,
tracing (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
This improves the smoketest by avoiding forced configurations resolution. This is not yet perfect as shadow plugin in this version do no allow to pass a lazy configurations.
Follow-up on #9761
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]