-
Notifications
You must be signed in to change notification settings - Fork 314
Fix possible IndexOutOfBoundsException in ExceptionReplay #9771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if chainedExceptionIndex stored into the snapshot is incorrect, it can lead to an IndexOutOfBoundsException. Protect against it
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 95e8cb0 | Docs | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (311.87 µs) : 286, 338
. : milestone, 312,
basic (276.786 µs) : 270, 284
. : milestone, 277,
loop (8.954 ms) : 8949, 8959
. : milestone, 8954,
section candidate
noprobe (319.131 µs) : 291, 347
. : milestone, 319,
basic (292.841 µs) : 287, 299
. : milestone, 293,
loop (8.962 ms) : 8958, 8967
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016557
Total [baseline] (10.7 s) : 0, 10699820
Agent [candidate] (1.014 s) : 0, 1014106
Total [candidate] (10.704 s) : 0, 10704446
section appsec
Agent [baseline] (1.194 s) : 0, 1194135
Total [baseline] (11.062 s) : 0, 11062068
Agent [candidate] (1.196 s) : 0, 1196180
Total [candidate] (11.084 s) : 0, 11084104
section iast
Agent [baseline] (1.15 s) : 0, 1149600
Total [baseline] (11.054 s) : 0, 11053567
Agent [candidate] (1.156 s) : 0, 1155914
Total [candidate] (4.334 s) : 0, 4333939
section profiling
Agent [baseline] (1.169 s) : 0, 1169139
Total [baseline] (11.107 s) : 0, 11106545
Agent [candidate] (1.159 s) : 0, 1158741
Total [candidate] (11.063 s) : 0, 11063266
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (692.744 ms) : 0, 692744
BytebuddyAgent [candidate] (692.156 ms) : 0, 692156
GlobalTracer [baseline] (241.665 ms) : 0, 241665
GlobalTracer [candidate] (241.658 ms) : 0, 241658
AppSec [baseline] (32.284 ms) : 0, 32284
AppSec [candidate] (32.513 ms) : 0, 32513
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (709.029 µs) : 0, 709
Remote Config [candidate] (703.914 µs) : 0, 704
Telemetry [baseline] (9.284 ms) : 0, 9284
Telemetry [candidate] (9.309 ms) : 0, 9309
Flare Poller [baseline] (10.948 ms) : 0, 10948
Flare Poller [candidate] (8.797 ms) : 0, 8797
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (717.679 ms) : 0, 717679
BytebuddyAgent [candidate] (719.534 ms) : 0, 719534
GlobalTracer [baseline] (234.935 ms) : 0, 234935
GlobalTracer [candidate] (234.849 ms) : 0, 234849
AppSec [baseline] (175.104 ms) : 0, 175104
AppSec [candidate] (174.424 ms) : 0, 174424
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (646.014 µs) : 0, 646
Remote Config [candidate] (633.507 µs) : 0, 634
Telemetry [baseline] (8.446 ms) : 0, 8446
Telemetry [candidate] (9.3 ms) : 0, 9300
Flare Poller [baseline] (3.889 ms) : 0, 3889
Flare Poller [candidate] (3.94 ms) : 0, 3940
IAST [baseline] (24.789 ms) : 0, 24789
IAST [candidate] (24.849 ms) : 0, 24849
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (814.286 ms) : 0, 814286
BytebuddyAgent [candidate] (819.266 ms) : 0, 819266
GlobalTracer [baseline] (231.198 ms) : 0, 231198
GlobalTracer [candidate] (232.407 ms) : 0, 232407
AppSec [baseline] (35.14 ms) : 0, 35140
AppSec [candidate] (35.394 ms) : 0, 35394
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (612.162 µs) : 0, 612
Remote Config [candidate] (579.99 µs) : 0, 580
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.827 ms) : 0, 8827
Flare Poller [baseline] (4.234 ms) : 0, 4234
Flare Poller [candidate] (4.056 ms) : 0, 4056
IAST [baseline] (26.316 ms) : 0, 26316
IAST [candidate] (26.44 ms) : 0, 26440
section profiling
ProfilingAgent [baseline] (108.633 ms) : 0, 108633
ProfilingAgent [candidate] (106.494 ms) : 0, 106494
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (726.027 ms) : 0, 726027
BytebuddyAgent [candidate] (720.964 ms) : 0, 720964
GlobalTracer [baseline] (219.142 ms) : 0, 219142
GlobalTracer [candidate] (217.506 ms) : 0, 217506
AppSec [baseline] (32.435 ms) : 0, 32435
AppSec [candidate] (32.386 ms) : 0, 32386
Debugger [baseline] (7.307 ms) : 0, 7307
Debugger [candidate] (7.208 ms) : 0, 7208
Remote Config [baseline] (816.207 µs) : 0, 816
Remote Config [candidate] (833.003 µs) : 0, 833
Telemetry [baseline] (15.378 ms) : 0, 15378
Telemetry [candidate] (15.226 ms) : 0, 15226
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.131 ms) : 0, 4131
Profiling [baseline] (110.026 ms) : 0, 110026
Profiling [candidate] (107.068 ms) : 0, 107068
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016442
Total [baseline] (8.703 s) : 0, 8702802
Agent [candidate] (1.016 s) : 0, 1015961
Total [candidate] (8.66 s) : 0, 8660157
section iast
Agent [baseline] (1.149 s) : 0, 1148505
Total [baseline] (9.279 s) : 0, 9279296
Agent [candidate] (1.15 s) : 0, 1149805
Total [candidate] (9.252 s) : 0, 9251903
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (693.524 ms) : 0, 693524
BytebuddyAgent [candidate] (692.928 ms) : 0, 692928
GlobalTracer [baseline] (242.031 ms) : 0, 242031
GlobalTracer [candidate] (241.653 ms) : 0, 241653
AppSec [baseline] (32.533 ms) : 0, 32533
AppSec [candidate] (32.356 ms) : 0, 32356
Debugger [baseline] (6.435 ms) : 0, 6435
Debugger [candidate] (6.451 ms) : 0, 6451
Remote Config [baseline] (714.219 µs) : 0, 714
Remote Config [candidate] (696.005 µs) : 0, 696
Telemetry [baseline] (9.3 ms) : 0, 9300
Telemetry [candidate] (9.158 ms) : 0, 9158
Flare Poller [baseline] (9.365 ms) : 0, 9365
Flare Poller [candidate] (10.165 ms) : 0, 10165
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (814.176 ms) : 0, 814176
BytebuddyAgent [candidate] (814.476 ms) : 0, 814476
GlobalTracer [baseline] (230.698 ms) : 0, 230698
GlobalTracer [candidate] (231.346 ms) : 0, 231346
AppSec [baseline] (34.042 ms) : 0, 34042
AppSec [candidate] (35.056 ms) : 0, 35056
Debugger [baseline] (6.185 ms) : 0, 6185
Debugger [candidate] (6.146 ms) : 0, 6146
Remote Config [baseline] (610.549 µs) : 0, 611
Remote Config [candidate] (604.946 µs) : 0, 605
Telemetry [baseline] (8.505 ms) : 0, 8505
Telemetry [candidate] (8.615 ms) : 0, 8615
Flare Poller [baseline] (4.251 ms) : 0, 4251
Flare Poller [candidate] (4.267 ms) : 0, 4267
IAST [baseline] (27.121 ms) : 0, 27121
IAST [candidate] (26.351 ms) : 0, 26351
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section baseline
no_agent (4.348 ms) : 4299, 4397
. : milestone, 4348,
iast (9.69 ms) : 9529, 9851
. : milestone, 9690,
iast_FULL (14.961 ms) : 14664, 15258
. : milestone, 14961,
iast_GLOBAL (10.646 ms) : 10457, 10834
. : milestone, 10646,
profiling (8.873 ms) : 8734, 9011
. : milestone, 8873,
tracing (7.769 ms) : 7658, 7879
. : milestone, 7769,
section candidate
no_agent (4.4 ms) : 4345, 4454
. : milestone, 4400,
iast (10.046 ms) : 9876, 10216
. : milestone, 10046,
iast_FULL (14.147 ms) : 13866, 14428
. : milestone, 14147,
iast_GLOBAL (9.941 ms) : 9770, 10111
. : milestone, 9941,
profiling (9.177 ms) : 9021, 9332
. : milestone, 9177,
tracing (7.764 ms) : 7645, 7883
. : milestone, 7764,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section baseline
no_agent (37.893 ms) : 37584, 38201
. : milestone, 37893,
appsec (48.418 ms) : 47994, 48842
. : milestone, 48418,
code_origins (42.628 ms) : 42254, 43001
. : milestone, 42628,
iast (44.366 ms) : 43989, 44743
. : milestone, 44366,
profiling (50.74 ms) : 50233, 51247
. : milestone, 50740,
tracing (47.397 ms) : 46982, 47813
. : milestone, 47397,
section candidate
no_agent (37.508 ms) : 37218, 37799
. : milestone, 37508,
appsec (47.385 ms) : 46957, 47812
. : milestone, 47385,
code_origins (43.714 ms) : 43329, 44100
. : milestone, 43714,
iast (46.403 ms) : 45986, 46819
. : milestone, 46403,
profiling (49.088 ms) : 48657, 49519
. : milestone, 49088,
tracing (44.184 ms) : 43807, 44561
. : milestone, 44184,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.721 ms) : 3502, 3940
. : milestone, 3721,
iast (2.214 ms) : 2150, 2278
. : milestone, 2214,
iast_GLOBAL (2.254 ms) : 2191, 2318
. : milestone, 2254,
profiling (2.079 ms) : 2027, 2132
. : milestone, 2079,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.682 ms) : 3467, 3897
. : milestone, 3682,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.036 ms) : 1986, 2085
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~95e8cb0c1a, baseline=1.55.0-SNAPSHOT~a6879bb9dd
dateFormat X
axisFormat %s
section baseline
no_agent (15.401 s) : 15401000, 15401000
. : milestone, 15401000,
appsec (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
iast (18.628 s) : 18628000, 18628000
. : milestone, 18628000,
iast_GLOBAL (18.018 s) : 18018000, 18018000
. : milestone, 18018000,
profiling (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
section candidate
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
iast (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
iast_GLOBAL (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
profiling (15.241 s) : 15241000, 15241000
. : milestone, 15241000,
tracing (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
|
What Does This Do
if chainedExceptionIndex stored into the snapshot is incorrect, it can lead to an IndexOutOfBoundsException. Protect against it
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]