Crashtracking: send ping message #9804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
added
type: enhancement
jbachorik
reviewed
Oct 20, 2025
Comment on lines
140
to
141
| // if we send more than 1 file via the CLI, let's make sure we have unique uuid (will be | ||
| // generated if null) |
There was a problem hiding this comment.
This will mean that only the first file will have UUID matching with the ping, right?
Is this expected/acceptable?
There was a problem hiding this comment.
we only send 1 file when the crash report are sent by the agent. The other mode is when the CLI is used (i.e. manual?). So I think yes. Perhaps we should not send the ping when multiple files are sent, wdyt?
There was a problem hiding this comment.
as discussed let's remove the possibility of uploading multiple files: f3e0d49
|
🎯 Code Coverage 🔗 Commit SHA: ee14b2b | Docs | Was this helpful? Give us feedback! |
jbachorik
reviewed
Oct 20, 2025
| log.error("Failed to upload crash file: {}", file, e); | ||
| CrashLog crashLog = CrashLogParser.fromHotspotCrashLog(uuid, content); | ||
| if (crashLog == null) { | ||
| log.error("Failed to parse crash log"); |
There was a problem hiding this comment.
I wonder, can we send this error message also to instrumentation telemetry, such that eg. our support engineers could easily check if there are any issues with parsing the crash logs at a customer?
There was a problem hiding this comment.
I initially misread the suggestion. Yes indeed. I added in 5d2a8ea a telemetry send marker and the info about the uuid so we can relate.
jbachorik
reviewed
Oct 20, 2025
| if (storedConfig == null) { | ||
| log.error("Unable to parse config file {}", configFile); | ||
| System.exit(1); | ||
| error += "Unable to parse config file"; |
There was a problem hiding this comment.
Perhaps, inserting a new line to make the error more readable?
The current code will just append to the previous error message.
There was a problem hiding this comment.
Yes it was not intended to concatenate the + is a typo (but yes ideally at this point we can have both failures so I'll insert a newline)
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
62e2d16 to
5d2a8ea
Compare
jbachorik
approved these changes
Oct 20, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016210
Total [baseline] (10.716 s) : 0, 10715574
Agent [candidate] (1.018 s) : 0, 1017621
Total [candidate] (10.671 s) : 0, 10671322
section appsec
Agent [baseline] (1.196 s) : 0, 1196497
Total [baseline] (10.882 s) : 0, 10882499
Agent [candidate] (1.193 s) : 0, 1192652
Total [candidate] (10.782 s) : 0, 10781739
section iast
Agent [baseline] (1.147 s) : 0, 1147282
Total [baseline] (11.08 s) : 0, 11080173
Agent [candidate] (1.152 s) : 0, 1151528
Total [candidate] (11.103 s) : 0, 11102603
section profiling
Agent [baseline] (1.163 s) : 0, 1162850
Total [baseline] (10.84 s) : 0, 10839644
Agent [candidate] (1.173 s) : 0, 1173383
Total [candidate] (10.823 s) : 0, 10823127
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (691.276 ms) : 0, 691276
BytebuddyAgent [candidate] (693.302 ms) : 0, 693302
GlobalTracer [baseline] (241.95 ms) : 0, 241950
GlobalTracer [candidate] (242.825 ms) : 0, 242825
AppSec [baseline] (32.29 ms) : 0, 32290
AppSec [candidate] (32.167 ms) : 0, 32167
Debugger [baseline] (6.286 ms) : 0, 6286
Debugger [candidate] (6.324 ms) : 0, 6324
Remote Config [baseline] (666.672 µs) : 0, 667
Remote Config [candidate] (658.385 µs) : 0, 658
Telemetry [baseline] (9.279 ms) : 0, 9279
Telemetry [candidate] (9.13 ms) : 0, 9130
Flare Poller [baseline] (11.922 ms) : 0, 11922
Flare Poller [candidate] (10.645 ms) : 0, 10645
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (719.035 ms) : 0, 719035
BytebuddyAgent [candidate] (717.495 ms) : 0, 717495
GlobalTracer [baseline] (234.89 ms) : 0, 234890
GlobalTracer [candidate] (234.521 ms) : 0, 234521
IAST [baseline] (25.012 ms) : 0, 25012
IAST [candidate] (24.942 ms) : 0, 24942
AppSec [baseline] (175.393 ms) : 0, 175393
AppSec [candidate] (174.021 ms) : 0, 174021
Debugger [baseline] (6.204 ms) : 0, 6204
Debugger [candidate] (6.098 ms) : 0, 6098
Remote Config [baseline] (634.602 µs) : 0, 635
Remote Config [candidate] (629.331 µs) : 0, 629
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.524 ms) : 0, 8524
Flare Poller [baseline] (3.964 ms) : 0, 3964
Flare Poller [candidate] (3.887 ms) : 0, 3887
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (812.362 ms) : 0, 812362
BytebuddyAgent [candidate] (815.595 ms) : 0, 815595
GlobalTracer [baseline] (230.793 ms) : 0, 230793
GlobalTracer [candidate] (231.572 ms) : 0, 231572
IAST [baseline] (26.645 ms) : 0, 26645
IAST [candidate] (26.805 ms) : 0, 26805
AppSec [baseline] (34.792 ms) : 0, 34792
AppSec [candidate] (35.014 ms) : 0, 35014
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (604.673 µs) : 0, 605
Remote Config [candidate] (597.433 µs) : 0, 597
Telemetry [baseline] (8.754 ms) : 0, 8754
Telemetry [candidate] (8.715 ms) : 0, 8715
Flare Poller [baseline] (4.394 ms) : 0, 4394
Flare Poller [candidate] (4.278 ms) : 0, 4278
section profiling
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (719.695 ms) : 0, 719695
BytebuddyAgent [candidate] (725.229 ms) : 0, 725229
GlobalTracer [baseline] (218.412 ms) : 0, 218412
GlobalTracer [candidate] (222.182 ms) : 0, 222182
AppSec [baseline] (32.34 ms) : 0, 32340
AppSec [candidate] (32.558 ms) : 0, 32558
Debugger [baseline] (6.67 ms) : 0, 6670
Debugger [candidate] (6.728 ms) : 0, 6728
Remote Config [baseline] (712.353 µs) : 0, 712
Remote Config [candidate] (673.842 µs) : 0, 674
Telemetry [baseline] (15.205 ms) : 0, 15205
Telemetry [candidate] (14.375 ms) : 0, 14375
Flare Poller [baseline] (4.915 ms) : 0, 4915
Flare Poller [candidate] (5.775 ms) : 0, 5775
ProfilingAgent [baseline] (109.707 ms) : 0, 109707
ProfilingAgent [candidate] (110.263 ms) : 0, 110263
Profiling [baseline] (110.319 ms) : 0, 110319
Profiling [candidate] (111.032 ms) : 0, 111032
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032556
Total [baseline] (8.653 s) : 0, 8653221
Agent [candidate] (1.017 s) : 0, 1017017
Total [candidate] (8.641 s) : 0, 8640841
section iast
Agent [baseline] (1.154 s) : 0, 1154191
Total [baseline] (9.294 s) : 0, 9294176
Agent [candidate] (1.15 s) : 0, 1149542
Total [candidate] (9.314 s) : 0, 9314179
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (705.156 ms) : 0, 705156
BytebuddyAgent [candidate] (692.347 ms) : 0, 692347
GlobalTracer [baseline] (244.697 ms) : 0, 244697
GlobalTracer [candidate] (242.794 ms) : 0, 242794
AppSec [baseline] (32.711 ms) : 0, 32711
AppSec [candidate] (32.266 ms) : 0, 32266
Debugger [baseline] (6.451 ms) : 0, 6451
Debugger [candidate] (6.288 ms) : 0, 6288
Remote Config [baseline] (686.024 µs) : 0, 686
Remote Config [candidate] (673.542 µs) : 0, 674
Telemetry [baseline] (9.468 ms) : 0, 9468
Telemetry [candidate] (9.281 ms) : 0, 9281
Flare Poller [baseline] (10.544 ms) : 0, 10544
Flare Poller [candidate] (10.924 ms) : 0, 10924
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (818.795 ms) : 0, 818795
BytebuddyAgent [candidate] (813.547 ms) : 0, 813547
GlobalTracer [baseline] (230.812 ms) : 0, 230812
GlobalTracer [candidate] (231.48 ms) : 0, 231480
IAST [baseline] (26.892 ms) : 0, 26892
IAST [candidate] (26.961 ms) : 0, 26961
AppSec [baseline] (34.97 ms) : 0, 34970
AppSec [candidate] (34.986 ms) : 0, 34986
Debugger [baseline] (6.179 ms) : 0, 6179
Debugger [candidate] (6.207 ms) : 0, 6207
Remote Config [baseline] (604.789 µs) : 0, 605
Remote Config [candidate] (606.583 µs) : 0, 607
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.674 ms) : 0, 8674
Flare Poller [baseline] (4.273 ms) : 0, 4273
Flare Poller [candidate] (4.243 ms) : 0, 4243
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 4 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section baseline
no_agent (36.103 ms) : 35815, 36391
. : milestone, 36103,
appsec (49.295 ms) : 48855, 49735
. : milestone, 49295,
code_origins (42.941 ms) : 42567, 43315
. : milestone, 42941,
iast (44.106 ms) : 43729, 44483
. : milestone, 44106,
profiling (48.026 ms) : 47526, 48526
. : milestone, 48026,
tracing (43.254 ms) : 42875, 43633
. : milestone, 43254,
section candidate
no_agent (37.288 ms) : 36980, 37597
. : milestone, 37288,
appsec (46.386 ms) : 45988, 46785
. : milestone, 46386,
code_origins (43.911 ms) : 43529, 44293
. : milestone, 43911,
iast (43.421 ms) : 43053, 43788
. : milestone, 43421,
profiling (48.183 ms) : 47744, 48622
. : milestone, 48183,
tracing (45.138 ms) : 44740, 45536
. : milestone, 45138,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section baseline
no_agent (4.509 ms) : 4457, 4561
. : milestone, 4509,
iast (9.455 ms) : 9300, 9610
. : milestone, 9455,
iast_FULL (14.348 ms) : 14064, 14633
. : milestone, 14348,
iast_GLOBAL (10.557 ms) : 10371, 10743
. : milestone, 10557,
profiling (8.86 ms) : 8712, 9008
. : milestone, 8860,
tracing (8.327 ms) : 8204, 8449
. : milestone, 8327,
section candidate
no_agent (4.33 ms) : 4279, 4382
. : milestone, 4330,
iast (10.081 ms) : 9910, 10253
. : milestone, 10081,
iast_FULL (14.652 ms) : 14363, 14941
. : milestone, 14652,
iast_GLOBAL (11.109 ms) : 10905, 11313
. : milestone, 11109,
profiling (8.761 ms) : 8620, 8903
. : milestone, 8761,
tracing (7.595 ms) : 7488, 7702
. : milestone, 7595,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.706 ms) : 3489, 3924
. : milestone, 3706,
iast (2.219 ms) : 2155, 2282
. : milestone, 2219,
iast_GLOBAL (2.267 ms) : 2203, 2330
. : milestone, 2267,
profiling (2.069 ms) : 2018, 2120
. : milestone, 2069,
tracing (2.051 ms) : 2001, 2101
. : milestone, 2051,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.675 ms) : 3463, 3887
. : milestone, 3675,
iast (2.231 ms) : 2167, 2295
. : milestone, 2231,
iast_GLOBAL (2.272 ms) : 2208, 2336
. : milestone, 2272,
profiling (2.504 ms) : 2339, 2669
. : milestone, 2504,
tracing (2.041 ms) : 1991, 2091
. : milestone, 2041,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ee14b2be1b, baseline=1.55.0-SNAPSHOT~60c4f68423
dateFormat X
axisFormat %s
section baseline
no_agent (15.656 s) : 15656000, 15656000
. : milestone, 15656000,
appsec (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
iast (18.503 s) : 18503000, 18503000
. : milestone, 18503000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
. : milestone, 17989000,
profiling (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
section candidate
no_agent (15.432 s) : 15432000, 15432000
. : milestone, 15432000,
appsec (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
iast (18.315 s) : 18315000, 18315000
. : milestone, 18315000,
iast_GLOBAL (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
profiling (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
|
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
6797413 to
d5e4dcd
Compare
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
3bda3f0 to
ecada21
Compare
gleocadie
approved these changes
Oct 21, 2025
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
1f4e825 to
0b0de74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Send a ping message to notify the telemetry that the crash tracking process is initiated.
The ping message will use the same UUID (stored under
crash_uuid) than the crash report. This will allow to know which report have a ping but don't have a linked report.Other than this, we also send a ping if we cannot parse the config file or the report, specifying it in the ping message.
Few improvements have also been done on the testing in order to refactor common assert and deterministic UUID usage
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]