-
Notifications
You must be signed in to change notification settings - Fork 314
Correct ref_protected requirement in trust policy
#9825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: f7633a5 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016711
Total [baseline] (8.634 s) : 0, 8633778
Agent [candidate] (1.017 s) : 0, 1016840
Total [candidate] (8.632 s) : 0, 8632362
section iast
Agent [baseline] (1.158 s) : 0, 1158110
Total [baseline] (9.273 s) : 0, 9272537
Agent [candidate] (1.15 s) : 0, 1150375
Total [candidate] (9.299 s) : 0, 9299490
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (693.338 ms) : 0, 693338
BytebuddyAgent [candidate] (692.76 ms) : 0, 692760
GlobalTracer [baseline] (241.959 ms) : 0, 241959
GlobalTracer [candidate] (242.24 ms) : 0, 242240
AppSec [baseline] (32.274 ms) : 0, 32274
AppSec [candidate] (32.214 ms) : 0, 32214
Debugger [baseline] (6.281 ms) : 0, 6281
Debugger [candidate] (6.3 ms) : 0, 6300
Remote Config [baseline] (669.785 µs) : 0, 670
Remote Config [candidate] (655.207 µs) : 0, 655
Telemetry [baseline] (9.315 ms) : 0, 9315
Telemetry [candidate] (9.24 ms) : 0, 9240
Flare Poller [baseline] (10.31 ms) : 0, 10310
Flare Poller [candidate] (10.915 ms) : 0, 10915
section iast
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (821.181 ms) : 0, 821181
BytebuddyAgent [candidate] (814.562 ms) : 0, 814562
GlobalTracer [baseline] (232.339 ms) : 0, 232339
GlobalTracer [candidate] (231.34 ms) : 0, 231340
AppSec [baseline] (35.082 ms) : 0, 35082
AppSec [candidate] (34.938 ms) : 0, 34938
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (6.194 ms) : 0, 6194
Remote Config [baseline] (605.21 µs) : 0, 605
Remote Config [candidate] (603.813 µs) : 0, 604
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.829 ms) : 0, 8829
Flare Poller [baseline] (4.301 ms) : 0, 4301
Flare Poller [candidate] (4.228 ms) : 0, 4228
IAST [baseline] (26.802 ms) : 0, 26802
IAST [candidate] (26.826 ms) : 0, 26826
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025913
Total [baseline] (10.706 s) : 0, 10706348
Agent [candidate] (1.018 s) : 0, 1018413
Total [candidate] (10.665 s) : 0, 10665356
section appsec
Agent [baseline] (1.196 s) : 0, 1195718
Total [baseline] (10.847 s) : 0, 10847303
Agent [candidate] (1.201 s) : 0, 1201117
Total [candidate] (10.799 s) : 0, 10799258
section iast
Agent [baseline] (1.165 s) : 0, 1165048
Total [baseline] (11.058 s) : 0, 11058282
Agent [candidate] (1.16 s) : 0, 1160407
Total [candidate] (11.082 s) : 0, 11081832
section profiling
Agent [baseline] (1.171 s) : 0, 1171317
Total [baseline] (10.891 s) : 0, 10890740
Agent [candidate] (1.177 s) : 0, 1176748
Total [candidate] (10.962 s) : 0, 10962184
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (699.457 ms) : 0, 699457
BytebuddyAgent [candidate] (693.585 ms) : 0, 693585
GlobalTracer [baseline] (244.566 ms) : 0, 244566
GlobalTracer [candidate] (242.754 ms) : 0, 242754
AppSec [baseline] (32.639 ms) : 0, 32639
AppSec [candidate] (32.234 ms) : 0, 32234
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.305 ms) : 0, 6305
Remote Config [baseline] (685.396 µs) : 0, 685
Remote Config [candidate] (666.232 µs) : 0, 666
Telemetry [baseline] (9.291 ms) : 0, 9291
Telemetry [candidate] (9.247 ms) : 0, 9247
Flare Poller [baseline] (10.057 ms) : 0, 10057
Flare Poller [candidate] (11.064 ms) : 0, 11064
section appsec
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (719.278 ms) : 0, 719278
BytebuddyAgent [candidate] (722.647 ms) : 0, 722647
GlobalTracer [baseline] (234.796 ms) : 0, 234796
GlobalTracer [candidate] (236.177 ms) : 0, 236177
AppSec [baseline] (174.924 ms) : 0, 174924
AppSec [candidate] (175.286 ms) : 0, 175286
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (6.151 ms) : 0, 6151
Remote Config [baseline] (645.692 µs) : 0, 646
Remote Config [candidate] (632.783 µs) : 0, 633
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.505 ms) : 0, 8505
Flare Poller [baseline] (3.89 ms) : 0, 3890
Flare Poller [candidate] (3.927 ms) : 0, 3927
IAST [baseline] (24.961 ms) : 0, 24961
IAST [candidate] (25.071 ms) : 0, 25071
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (826.041 ms) : 0, 826041
BytebuddyAgent [candidate] (822.702 ms) : 0, 822702
GlobalTracer [baseline] (233.736 ms) : 0, 233736
GlobalTracer [candidate] (233.045 ms) : 0, 233045
AppSec [baseline] (35.498 ms) : 0, 35498
AppSec [candidate] (35.233 ms) : 0, 35233
Debugger [baseline] (6.135 ms) : 0, 6135
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (597.871 µs) : 0, 598
Remote Config [candidate] (601.317 µs) : 0, 601
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.669 ms) : 0, 8669
Flare Poller [baseline] (4.351 ms) : 0, 4351
Flare Poller [candidate] (4.237 ms) : 0, 4237
IAST [baseline] (26.805 ms) : 0, 26805
IAST [candidate] (26.741 ms) : 0, 26741
section profiling
ProfilingAgent [baseline] (109.658 ms) : 0, 109658
ProfilingAgent [candidate] (110.058 ms) : 0, 110058
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (725.578 ms) : 0, 725578
BytebuddyAgent [candidate] (729.072 ms) : 0, 729072
GlobalTracer [baseline] (220.251 ms) : 0, 220251
GlobalTracer [candidate] (220.971 ms) : 0, 220971
AppSec [baseline] (32.521 ms) : 0, 32521
AppSec [candidate] (32.916 ms) : 0, 32916
Debugger [baseline] (6.741 ms) : 0, 6741
Debugger [candidate] (7.585 ms) : 0, 7585
Remote Config [baseline] (706.893 µs) : 0, 707
Remote Config [candidate] (699.153 µs) : 0, 699
Telemetry [baseline] (15.166 ms) : 0, 15166
Telemetry [candidate] (14.631 ms) : 0, 14631
Flare Poller [baseline] (5.036 ms) : 0, 5036
Flare Poller [candidate] (5.001 ms) : 0, 5001
Profiling [baseline] (110.272 ms) : 0, 110272
Profiling [candidate] (110.689 ms) : 0, 110689
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section baseline
no_agent (4.407 ms) : 4351, 4462
. : milestone, 4407,
iast (9.717 ms) : 9555, 9879
. : milestone, 9717,
iast_FULL (14.369 ms) : 14080, 14657
. : milestone, 14369,
iast_GLOBAL (10.4 ms) : 10218, 10583
. : milestone, 10400,
profiling (9.097 ms) : 8961, 9234
. : milestone, 9097,
tracing (7.795 ms) : 7675, 7914
. : milestone, 7795,
section candidate
no_agent (4.33 ms) : 4280, 4380
. : milestone, 4330,
iast (9.904 ms) : 9739, 10069
. : milestone, 9904,
iast_FULL (13.788 ms) : 13515, 14060
. : milestone, 13788,
iast_GLOBAL (10.301 ms) : 10120, 10482
. : milestone, 10301,
profiling (8.843 ms) : 8703, 8983
. : milestone, 8843,
tracing (7.535 ms) : 7423, 7648
. : milestone, 7535,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section baseline
no_agent (36.335 ms) : 36043, 36627
. : milestone, 36335,
appsec (49.449 ms) : 48999, 49899
. : milestone, 49449,
code_origins (43.762 ms) : 43390, 44134
. : milestone, 43762,
iast (45.256 ms) : 44867, 45645
. : milestone, 45256,
profiling (45.997 ms) : 45571, 46423
. : milestone, 45997,
tracing (43.475 ms) : 43105, 43844
. : milestone, 43475,
section candidate
no_agent (35.755 ms) : 35469, 36040
. : milestone, 35755,
appsec (46.779 ms) : 46359, 47199
. : milestone, 46779,
code_origins (43.5 ms) : 43122, 43878
. : milestone, 43500,
iast (44.867 ms) : 44473, 45260
. : milestone, 44867,
profiling (48.345 ms) : 47898, 48791
. : milestone, 48345,
tracing (42.643 ms) : 42266, 43021
. : milestone, 42643,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.645 ms) : 3432, 3859
. : milestone, 3645,
iast (2.204 ms) : 2140, 2268
. : milestone, 2204,
iast_GLOBAL (2.248 ms) : 2184, 2313
. : milestone, 2248,
profiling (2.07 ms) : 2017, 2123
. : milestone, 2070,
tracing (2.016 ms) : 1967, 2066
. : milestone, 2016,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.697 ms) : 3479, 3916
. : milestone, 3697,
iast (2.199 ms) : 2136, 2263
. : milestone, 2199,
iast_GLOBAL (2.248 ms) : 2183, 2312
. : milestone, 2248,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.021 ms) : 1971, 2071
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f7633a5e24, baseline=1.55.0-SNAPSHOT~e6bf289028
dateFormat X
axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
appsec (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
iast (18.795 s) : 18795000, 18795000
. : milestone, 18795000,
iast_GLOBAL (18.017 s) : 18017000, 18017000
. : milestone, 18017000,
profiling (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
section candidate
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
iast (18.477 s) : 18477000, 18477000
. : milestone, 18477000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
. : milestone, 17919000,
profiling (15.435 s) : 15435000, 15435000
. : milestone, 15435000,
tracing (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
|
What Does This Do
Revert #9824 change to incorrect trust policy and instead remove
ref_protectedfrom theupdate-system-teststrust policyMotivation
Fix my mistake :(
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]