-
Notifications
You must be signed in to change notification settings - Fork 314
Adding span builder reuse variable #9839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙇
|
🎯 Code Coverage 🔗 Commit SHA: 392147d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028740
Total [baseline] (10.76 s) : 0, 10760124
Agent [candidate] (1.03 s) : 0, 1029789
Total [candidate] (10.814 s) : 0, 10814340
section appsec
Agent [baseline] (1.197 s) : 0, 1197363
Total [baseline] (10.876 s) : 0, 10875559
Agent [candidate] (1.213 s) : 0, 1213282
Total [candidate] (10.944 s) : 0, 10943556
section iast
Agent [baseline] (1.168 s) : 0, 1168221
Total [baseline] (11.126 s) : 0, 11126339
Agent [candidate] (1.156 s) : 0, 1156331
Total [candidate] (11.063 s) : 0, 11063153
section profiling
Agent [baseline] (1.171 s) : 0, 1170543
Total [baseline] (10.835 s) : 0, 10834598
Agent [candidate] (1.172 s) : 0, 1171898
Total [candidate] (10.844 s) : 0, 10844220
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (701.51 ms) : 0, 701510
BytebuddyAgent [candidate] (702.247 ms) : 0, 702247
GlobalTracer [baseline] (244.262 ms) : 0, 244262
GlobalTracer [candidate] (244.757 ms) : 0, 244757
AppSec [baseline] (32.148 ms) : 0, 32148
AppSec [candidate] (32.116 ms) : 0, 32116
Debugger [baseline] (6.345 ms) : 0, 6345
Debugger [candidate] (6.356 ms) : 0, 6356
Remote Config [baseline] (691.574 µs) : 0, 692
Remote Config [candidate] (675.154 µs) : 0, 675
Telemetry [baseline] (15.304 ms) : 0, 15304
Telemetry [candidate] (16.731 ms) : 0, 16731
Flare Poller [baseline] (5.867 ms) : 0, 5867
Flare Poller [candidate] (4.287 ms) : 0, 4287
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (721.794 ms) : 0, 721794
BytebuddyAgent [candidate] (732.918 ms) : 0, 732918
GlobalTracer [baseline] (234.893 ms) : 0, 234893
GlobalTracer [candidate] (238.149 ms) : 0, 238149
AppSec [baseline] (174.429 ms) : 0, 174429
AppSec [candidate] (175.103 ms) : 0, 175103
Debugger [baseline] (5.914 ms) : 0, 5914
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (623.661 µs) : 0, 624
Remote Config [candidate] (642.089 µs) : 0, 642
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (8.499 ms) : 0, 8499
Flare Poller [baseline] (3.92 ms) : 0, 3920
Flare Poller [candidate] (3.909 ms) : 0, 3909
IAST [baseline] (24.862 ms) : 0, 24862
IAST [candidate] (25.298 ms) : 0, 25298
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (828.916 ms) : 0, 828916
BytebuddyAgent [candidate] (820.138 ms) : 0, 820138
GlobalTracer [baseline] (235.17 ms) : 0, 235170
GlobalTracer [candidate] (233.148 ms) : 0, 233148
AppSec [baseline] (29.009 ms) : 0, 29009
AppSec [candidate] (29.418 ms) : 0, 29418
Debugger [baseline] (6.154 ms) : 0, 6154
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (615.053 µs) : 0, 615
Remote Config [candidate] (596.199 µs) : 0, 596
Telemetry [baseline] (8.526 ms) : 0, 8526
Telemetry [candidate] (8.503 ms) : 0, 8503
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.124 ms) : 0, 4124
IAST [baseline] (32.698 ms) : 0, 32698
IAST [candidate] (31.613 ms) : 0, 31613
section profiling
ProfilingAgent [baseline] (108.838 ms) : 0, 108838
ProfilingAgent [candidate] (108.93 ms) : 0, 108930
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (724.856 ms) : 0, 724856
BytebuddyAgent [candidate] (726.388 ms) : 0, 726388
GlobalTracer [baseline] (220.268 ms) : 0, 220268
GlobalTracer [candidate] (220.004 ms) : 0, 220004
AppSec [baseline] (32.288 ms) : 0, 32288
AppSec [candidate] (32.183 ms) : 0, 32183
Debugger [baseline] (11.389 ms) : 0, 11389
Debugger [candidate] (14.746 ms) : 0, 14746
Remote Config [baseline] (706.173 µs) : 0, 706
Remote Config [candidate] (718.056 µs) : 0, 718
Telemetry [baseline] (11.444 ms) : 0, 11444
Telemetry [candidate] (8.146 ms) : 0, 8146
Flare Poller [baseline] (4.14 ms) : 0, 4140
Flare Poller [candidate] (4.116 ms) : 0, 4116
Profiling [baseline] (109.497 ms) : 0, 109497
Profiling [candidate] (109.539 ms) : 0, 109539
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032255
Total [baseline] (8.661 s) : 0, 8660539
Agent [candidate] (1.034 s) : 0, 1034139
Total [candidate] (8.664 s) : 0, 8663593
section iast
Agent [baseline] (1.159 s) : 0, 1158585
Total [baseline] (9.321 s) : 0, 9320692
Agent [candidate] (1.174 s) : 0, 1173514
Total [candidate] (9.371 s) : 0, 9371367
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (704.504 ms) : 0, 704504
BytebuddyAgent [candidate] (705.496 ms) : 0, 705496
GlobalTracer [baseline] (245.225 ms) : 0, 245225
GlobalTracer [candidate] (245.515 ms) : 0, 245515
AppSec [baseline] (32.461 ms) : 0, 32461
AppSec [candidate] (32.513 ms) : 0, 32513
Debugger [baseline] (6.415 ms) : 0, 6415
Debugger [candidate] (6.468 ms) : 0, 6468
Remote Config [baseline] (679.158 µs) : 0, 679
Remote Config [candidate] (683.704 µs) : 0, 684
Telemetry [baseline] (13.087 ms) : 0, 13087
Telemetry [candidate] (15.781 ms) : 0, 15781
Flare Poller [baseline] (7.261 ms) : 0, 7261
Flare Poller [candidate] (5.051 ms) : 0, 5051
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (821.572 ms) : 0, 821572
BytebuddyAgent [candidate] (833.782 ms) : 0, 833782
GlobalTracer [baseline] (233.271 ms) : 0, 233271
GlobalTracer [candidate] (235.712 ms) : 0, 235712
IAST [baseline] (30.825 ms) : 0, 30825
IAST [candidate] (32.099 ms) : 0, 32099
AppSec [baseline] (30.727 ms) : 0, 30727
AppSec [candidate] (29.536 ms) : 0, 29536
Debugger [baseline] (6.182 ms) : 0, 6182
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (604.297 µs) : 0, 604
Remote Config [candidate] (591.632 µs) : 0, 592
Telemetry [baseline] (8.525 ms) : 0, 8525
Telemetry [candidate] (8.349 ms) : 0, 8349
Flare Poller [baseline] (4.162 ms) : 0, 4162
Flare Poller [candidate] (4.17 ms) : 0, 4170
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section baseline
no_agent (4.37 ms) : 4320, 4420
. : milestone, 4370,
iast (9.933 ms) : 9765, 10100
. : milestone, 9933,
iast_FULL (13.909 ms) : 13635, 14183
. : milestone, 13909,
iast_GLOBAL (11.294 ms) : 11086, 11503
. : milestone, 11294,
profiling (9.302 ms) : 9149, 9455
. : milestone, 9302,
tracing (7.797 ms) : 7686, 7908
. : milestone, 7797,
section candidate
no_agent (4.409 ms) : 4358, 4459
. : milestone, 4409,
iast (10.425 ms) : 10250, 10601
. : milestone, 10425,
iast_FULL (13.672 ms) : 13399, 13946
. : milestone, 13672,
iast_GLOBAL (11.263 ms) : 11060, 11466
. : milestone, 11263,
profiling (9.162 ms) : 9021, 9304
. : milestone, 9162,
tracing (8.068 ms) : 7950, 8185
. : milestone, 8068,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section baseline
no_agent (36.423 ms) : 36130, 36717
. : milestone, 36423,
appsec (48.663 ms) : 48215, 49111
. : milestone, 48663,
code_origins (43.347 ms) : 42967, 43727
. : milestone, 43347,
iast (43.641 ms) : 43262, 44020
. : milestone, 43641,
profiling (48.835 ms) : 48373, 49297
. : milestone, 48835,
tracing (44.949 ms) : 44572, 45326
. : milestone, 44949,
section candidate
no_agent (38.208 ms) : 37912, 38505
. : milestone, 38208,
appsec (49.503 ms) : 49074, 49932
. : milestone, 49503,
code_origins (44.23 ms) : 43848, 44612
. : milestone, 44230,
iast (46.558 ms) : 46150, 46966
. : milestone, 46558,
profiling (49.288 ms) : 48810, 49767
. : milestone, 49288,
tracing (43.835 ms) : 43474, 44195
. : milestone, 43835,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (3.649 ms) : 3436, 3862
. : milestone, 3649,
iast (2.243 ms) : 2178, 2307
. : milestone, 2243,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.063 ms) : 2011, 2114
. : milestone, 2063,
tracing (2.041 ms) : 1991, 2091
. : milestone, 2041,
section candidate
no_agent (1.489 ms) : 1478, 1501
. : milestone, 1489,
appsec (2.471 ms) : 2419, 2522
. : milestone, 2471,
iast (2.238 ms) : 2174, 2302
. : milestone, 2238,
iast_GLOBAL (2.27 ms) : 2205, 2335
. : milestone, 2270,
profiling (2.092 ms) : 2038, 2145
. : milestone, 2092,
tracing (2.04 ms) : 1990, 2089
. : milestone, 2040,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~392147d9a5, baseline=1.55.0-SNAPSHOT~cdebbd8dc3
dateFormat X
axisFormat %s
section baseline
no_agent (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
appsec (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
iast (18.367 s) : 18367000, 18367000
. : milestone, 18367000,
iast_GLOBAL (17.846 s) : 17846000, 17846000
. : milestone, 17846000,
profiling (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
tracing (15.329 s) : 15329000, 15329000
. : milestone, 15329000,
section candidate
no_agent (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
appsec (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
iast (18.537 s) : 18537000, 18537000
. : milestone, 18537000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
. : milestone, 17909000,
profiling (15.838 s) : 15838000, 15838000
. : milestone, 15838000,
tracing (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
|
What Does This Do
Adding span builder reuse variable to known configurations
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]