-
Notifications
You must be signed in to change notification settings - Fork 314
Try isolating logic that creates PR #9845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cca9a22 to
f36e518
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 66a7197 | Docs | Was this helpful? Give us feedback! |
85d3509 to
66a7197
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029547
Total [baseline] (10.771 s) : 0, 10770657
Agent [candidate] (1.028 s) : 0, 1028326
Total [candidate] (10.811 s) : 0, 10810947
section appsec
Agent [baseline] (1.211 s) : 0, 1210876
Total [baseline] (10.994 s) : 0, 10994220
Agent [candidate] (1.203 s) : 0, 1203099
Total [candidate] (10.853 s) : 0, 10853153
section iast
Agent [baseline] (1.171 s) : 0, 1171059
Total [baseline] (11.171 s) : 0, 11171273
Agent [candidate] (1.158 s) : 0, 1157821
Total [candidate] (10.159 s) : 0, 10159316
section profiling
Agent [baseline] (1.172 s) : 0, 1171522
Total [baseline] (10.853 s) : 0, 10852757
Agent [candidate] (1.186 s) : 0, 1185606
Total [candidate] (10.968 s) : 0, 10968390
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (701.853 ms) : 0, 701853
BytebuddyAgent [candidate] (700.818 ms) : 0, 700818
GlobalTracer [baseline] (244.616 ms) : 0, 244616
GlobalTracer [candidate] (244.709 ms) : 0, 244709
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (32.306 ms) : 0, 32306
Debugger [baseline] (6.377 ms) : 0, 6377
Debugger [candidate] (6.337 ms) : 0, 6337
Remote Config [baseline] (687.717 µs) : 0, 688
Remote Config [candidate] (678.66 µs) : 0, 679
Telemetry [baseline] (13.735 ms) : 0, 13735
Telemetry [candidate] (15.796 ms) : 0, 15796
Flare Poller [baseline] (7.368 ms) : 0, 7368
Flare Poller [candidate] (5.044 ms) : 0, 5044
section appsec
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (731.022 ms) : 0, 731022
BytebuddyAgent [candidate] (725.988 ms) : 0, 725988
GlobalTracer [baseline] (237.861 ms) : 0, 237861
GlobalTracer [candidate] (235.737 ms) : 0, 235737
IAST [baseline] (25.239 ms) : 0, 25239
IAST [candidate] (25.013 ms) : 0, 25013
AppSec [baseline] (175.125 ms) : 0, 175125
AppSec [candidate] (174.845 ms) : 0, 174845
Debugger [baseline] (5.93 ms) : 0, 5930
Debugger [candidate] (5.929 ms) : 0, 5929
Remote Config [baseline] (629.724 µs) : 0, 630
Remote Config [candidate] (633.377 µs) : 0, 633
Telemetry [baseline] (8.44 ms) : 0, 8440
Telemetry [candidate] (8.448 ms) : 0, 8448
Flare Poller [baseline] (3.907 ms) : 0, 3907
Flare Poller [candidate] (3.892 ms) : 0, 3892
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (830.827 ms) : 0, 830827
BytebuddyAgent [candidate] (821.455 ms) : 0, 821455
GlobalTracer [baseline] (235.493 ms) : 0, 235493
GlobalTracer [candidate] (233.262 ms) : 0, 233262
IAST [baseline] (31.138 ms) : 0, 31138
IAST [candidate] (33.594 ms) : 0, 33594
AppSec [baseline] (31.016 ms) : 0, 31016
AppSec [candidate] (27.6 ms) : 0, 27600
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (613.543 µs) : 0, 614
Remote Config [candidate] (605.227 µs) : 0, 605
Telemetry [baseline] (8.635 ms) : 0, 8635
Telemetry [candidate] (8.401 ms) : 0, 8401
Flare Poller [baseline] (4.156 ms) : 0, 4156
Flare Poller [candidate] (4.043 ms) : 0, 4043
section profiling
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (725.076 ms) : 0, 725076
BytebuddyAgent [candidate] (735.099 ms) : 0, 735099
GlobalTracer [baseline] (220.141 ms) : 0, 220141
GlobalTracer [candidate] (222.086 ms) : 0, 222086
AppSec [baseline] (32.301 ms) : 0, 32301
AppSec [candidate] (33.581 ms) : 0, 33581
Debugger [baseline] (11.464 ms) : 0, 11464
Debugger [candidate] (12.328 ms) : 0, 12328
Remote Config [baseline] (689.974 µs) : 0, 690
Remote Config [candidate] (1.464 ms) : 0, 1464
Telemetry [baseline] (11.493 ms) : 0, 11493
Telemetry [candidate] (9.091 ms) : 0, 9091
Flare Poller [baseline] (4.126 ms) : 0, 4126
Flare Poller [candidate] (4.167 ms) : 0, 4167
ProfilingAgent [baseline] (109.412 ms) : 0, 109412
ProfilingAgent [candidate] (110.306 ms) : 0, 110306
Profiling [baseline] (110.032 ms) : 0, 110032
Profiling [candidate] (110.935 ms) : 0, 110935
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1033126
Total [baseline] (8.676 s) : 0, 8676108
Agent [candidate] (1.026 s) : 0, 1026328
Total [candidate] (8.673 s) : 0, 8673098
section iast
Agent [baseline] (1.169 s) : 0, 1168535
Total [baseline] (9.363 s) : 0, 9363267
Agent [candidate] (1.161 s) : 0, 1161367
Total [candidate] (9.367 s) : 0, 9366612
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (704.309 ms) : 0, 704309
BytebuddyAgent [candidate] (699.672 ms) : 0, 699672
GlobalTracer [baseline] (245.394 ms) : 0, 245394
GlobalTracer [candidate] (244.159 ms) : 0, 244159
AppSec [baseline] (32.516 ms) : 0, 32516
AppSec [candidate] (32.117 ms) : 0, 32117
Debugger [baseline] (6.467 ms) : 0, 6467
Debugger [candidate] (6.353 ms) : 0, 6353
Remote Config [baseline] (691.529 µs) : 0, 692
Remote Config [candidate] (671.691 µs) : 0, 672
Telemetry [baseline] (13.018 ms) : 0, 13018
Telemetry [candidate] (15.049 ms) : 0, 15049
Flare Poller [baseline] (7.974 ms) : 0, 7974
Flare Poller [candidate] (5.657 ms) : 0, 5657
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (829.576 ms) : 0, 829576
BytebuddyAgent [candidate] (823.507 ms) : 0, 823507
GlobalTracer [baseline] (234.665 ms) : 0, 234665
GlobalTracer [candidate] (234.496 ms) : 0, 234496
AppSec [baseline] (29.966 ms) : 0, 29966
AppSec [candidate] (30.735 ms) : 0, 30735
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (6.057 ms) : 0, 6057
Remote Config [baseline] (621.495 µs) : 0, 621
Remote Config [candidate] (587.643 µs) : 0, 588
Telemetry [baseline] (8.596 ms) : 0, 8596
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (4.19 ms) : 0, 4190
Flare Poller [candidate] (4.116 ms) : 0, 4116
IAST [baseline] (31.867 ms) : 0, 31867
IAST [candidate] (30.649 ms) : 0, 30649
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (4.338 ms) : 4290, 4386
. : milestone, 4338,
iast (9.683 ms) : 9520, 9845
. : milestone, 9683,
iast_FULL (14.197 ms) : 13916, 14478
. : milestone, 14197,
iast_GLOBAL (10.885 ms) : 10689, 11081
. : milestone, 10885,
profiling (9.273 ms) : 9118, 9427
. : milestone, 9273,
tracing (7.92 ms) : 7797, 8043
. : milestone, 7920,
section candidate
no_agent (4.328 ms) : 4277, 4380
. : milestone, 4328,
iast (10.422 ms) : 10245, 10599
. : milestone, 10422,
iast_FULL (13.915 ms) : 13636, 14194
. : milestone, 13915,
iast_GLOBAL (10.898 ms) : 10700, 11095
. : milestone, 10898,
profiling (9.125 ms) : 8970, 9280
. : milestone, 9125,
tracing (7.716 ms) : 7607, 7826
. : milestone, 7716,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (36.91 ms) : 36618, 37202
. : milestone, 36910,
appsec (49.988 ms) : 49553, 50423
. : milestone, 49988,
code_origins (43.698 ms) : 43339, 44057
. : milestone, 43698,
iast (44.695 ms) : 44291, 45098
. : milestone, 44695,
profiling (50.164 ms) : 49647, 50682
. : milestone, 50164,
tracing (43.513 ms) : 43154, 43872
. : milestone, 43513,
section candidate
no_agent (36.525 ms) : 36238, 36811
. : milestone, 36525,
appsec (47.443 ms) : 47028, 47858
. : milestone, 47443,
code_origins (43.783 ms) : 43398, 44167
. : milestone, 43783,
iast (45.822 ms) : 45418, 46225
. : milestone, 45822,
profiling (48.902 ms) : 48468, 49335
. : milestone, 48902,
tracing (44.579 ms) : 44208, 44950
. : milestone, 44579,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
appsec (14.712 s) : 14712000, 14712000
. : milestone, 14712000,
iast (18.467 s) : 18467000, 18467000
. : milestone, 18467000,
iast_GLOBAL (18.197 s) : 18197000, 18197000
. : milestone, 18197000,
profiling (15.65 s) : 15650000, 15650000
. : milestone, 15650000,
tracing (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
section candidate
no_agent (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
appsec (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
iast (18.691 s) : 18691000, 18691000
. : milestone, 18691000,
iast_GLOBAL (18.426 s) : 18426000, 18426000
. : milestone, 18426000,
profiling (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
tracing (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~66a71971cf, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.537 ms) : 2483, 2592
. : milestone, 2537,
iast (2.235 ms) : 2171, 2300
. : milestone, 2235,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.043 ms) : 1993, 2093
. : milestone, 2043,
section candidate
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.683 ms) : 3468, 3898
. : milestone, 3683,
iast (2.232 ms) : 2167, 2296
. : milestone, 2232,
iast_GLOBAL (2.274 ms) : 2210, 2339
. : milestone, 2274,
profiling (2.067 ms) : 2015, 2118
. : milestone, 2067,
tracing (2.046 ms) : 1996, 2096
. : milestone, 2046,
|
What Does This Do
This PR comments out the logic that creates the initial
release/v*branch such that the workflow should now only create a PR that pins system tests off of therelease/v0.0.xbranch that already exists. The PR also makes the workflow and trust policy as identical as possible to successful ones such asupdate-docker-imageandupdate-gradle-dependencies.If the workflow succeeds after this PR is merged, then the current failure must be related to the commented out sections. My theory would then be that the github token and dd-octo-sts token are interfering with each other, and I'll try putting the
release/v*branch creation logic in a separate workflow.If the workflow fails after this PR is merged, then the issue may be something specific about being triggered from a tag (this workflow) vs. from master/schedule (successful workflows) that's causing the issue with the policy validation. That is the main difference I see.
Motivation
Workflow still failing with same Resource Accessibility error :( https://github.com/DataDog/dd-trace-java/actions/runs/18750881577/job/53489880182
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]