Simplify InstanceStore API #9861
Merged
+58
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎯 Code Coverage 🔗 Commit SHA: 6a8ec87 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032601
Total [baseline] (8.69 s) : 0, 8689603
Agent [candidate] (1.03 s) : 0, 1029719
Total [candidate] (8.66 s) : 0, 8660242
section iast
Agent [baseline] (1.162 s) : 0, 1162328
Total [baseline] (9.371 s) : 0, 9370703
Agent [candidate] (1.162 s) : 0, 1162421
Total [candidate] (9.405 s) : 0, 9404773
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (704.304 ms) : 0, 704304
BytebuddyAgent [candidate] (701.096 ms) : 0, 701096
GlobalTracer [baseline] (245.503 ms) : 0, 245503
GlobalTracer [candidate] (245.232 ms) : 0, 245232
AppSec [baseline] (32.12 ms) : 0, 32120
AppSec [candidate] (32.442 ms) : 0, 32442
Debugger [baseline] (6.377 ms) : 0, 6377
Debugger [candidate] (6.393 ms) : 0, 6393
Remote Config [baseline] (680.286 µs) : 0, 680
Remote Config [candidate] (673.274 µs) : 0, 673
Telemetry [baseline] (16.709 ms) : 0, 16709
Telemetry [candidate] (13.997 ms) : 0, 13997
Flare Poller [baseline] (4.192 ms) : 0, 4192
Flare Poller [candidate] (7.298 ms) : 0, 7298
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (824.477 ms) : 0, 824477
BytebuddyAgent [candidate] (824.852 ms) : 0, 824852
GlobalTracer [baseline] (233.887 ms) : 0, 233887
GlobalTracer [candidate] (234.214 ms) : 0, 234214
AppSec [baseline] (30.821 ms) : 0, 30821
AppSec [candidate] (28.871 ms) : 0, 28871
Debugger [baseline] (6.062 ms) : 0, 6062
Debugger [candidate] (6.074 ms) : 0, 6074
Remote Config [baseline] (605.069 µs) : 0, 605
Remote Config [candidate] (600.183 µs) : 0, 600
Telemetry [baseline] (8.349 ms) : 0, 8349
Telemetry [candidate] (8.441 ms) : 0, 8441
Flare Poller [baseline] (4.148 ms) : 0, 4148
Flare Poller [candidate] (4.128 ms) : 0, 4128
IAST [baseline] (31.182 ms) : 0, 31182
IAST [candidate] (32.569 ms) : 0, 32569
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037372
Total [baseline] (10.892 s) : 0, 10892369
Agent [candidate] (1.033 s) : 0, 1032585
Total [candidate] (10.814 s) : 0, 10814013
section appsec
Agent [baseline] (1.204 s) : 0, 1204254
Total [baseline] (10.9 s) : 0, 10900365
Agent [candidate] (1.213 s) : 0, 1213322
Total [candidate] (11.003 s) : 0, 11003447
section iast
Agent [baseline] (1.172 s) : 0, 1172069
Total [baseline] (11.199 s) : 0, 11198878
Agent [candidate] (1.163 s) : 0, 1163310
Total [candidate] (11.116 s) : 0, 11115951
section profiling
Agent [baseline] (1.174 s) : 0, 1173959
Total [baseline] (10.954 s) : 0, 10953559
Agent [candidate] (1.181 s) : 0, 1181404
Total [candidate] (10.888 s) : 0, 10887545
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (707.389 ms) : 0, 707389
BytebuddyAgent [candidate] (704.164 ms) : 0, 704164
GlobalTracer [baseline] (246.719 ms) : 0, 246719
GlobalTracer [candidate] (245.387 ms) : 0, 245387
AppSec [baseline] (32.46 ms) : 0, 32460
AppSec [candidate] (32.322 ms) : 0, 32322
Debugger [baseline] (6.418 ms) : 0, 6418
Debugger [candidate] (6.368 ms) : 0, 6368
Remote Config [baseline] (682.476 µs) : 0, 682
Remote Config [candidate] (683.026 µs) : 0, 683
Telemetry [baseline] (14.383 ms) : 0, 14383
Telemetry [candidate] (14.403 ms) : 0, 14403
Flare Poller [baseline] (6.458 ms) : 0, 6458
Flare Poller [candidate] (6.49 ms) : 0, 6490
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (727.346 ms) : 0, 727346
BytebuddyAgent [candidate] (732.647 ms) : 0, 732647
GlobalTracer [baseline] (235.818 ms) : 0, 235818
GlobalTracer [candidate] (238.12 ms) : 0, 238120
AppSec [baseline] (174.535 ms) : 0, 174535
AppSec [candidate] (175.416 ms) : 0, 175416
Debugger [baseline] (5.953 ms) : 0, 5953
Debugger [candidate] (5.959 ms) : 0, 5959
Remote Config [baseline] (629.413 µs) : 0, 629
Remote Config [candidate] (628.706 µs) : 0, 629
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.496 ms) : 0, 8496
Flare Poller [baseline] (3.899 ms) : 0, 3899
Flare Poller [candidate] (3.955 ms) : 0, 3955
IAST [baseline] (24.906 ms) : 0, 24906
IAST [candidate] (25.291 ms) : 0, 25291
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (831.785 ms) : 0, 831785
BytebuddyAgent [candidate] (825.272 ms) : 0, 825272
GlobalTracer [baseline] (235.698 ms) : 0, 235698
GlobalTracer [candidate] (234.554 ms) : 0, 234554
AppSec [baseline] (31.909 ms) : 0, 31909
AppSec [candidate] (28.038 ms) : 0, 28038
Debugger [baseline] (6.199 ms) : 0, 6199
Debugger [candidate] (6.161 ms) : 0, 6161
Remote Config [baseline] (615.656 µs) : 0, 616
Remote Config [candidate] (591.672 µs) : 0, 592
Telemetry [baseline] (8.448 ms) : 0, 8448
Telemetry [candidate] (8.37 ms) : 0, 8370
Flare Poller [baseline] (4.173 ms) : 0, 4173
Flare Poller [candidate] (4.147 ms) : 0, 4147
IAST [baseline] (30.18 ms) : 0, 30180
IAST [candidate] (33.449 ms) : 0, 33449
section profiling
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (726.274 ms) : 0, 726274
BytebuddyAgent [candidate] (731.287 ms) : 0, 731287
GlobalTracer [baseline] (220.499 ms) : 0, 220499
GlobalTracer [candidate] (221.928 ms) : 0, 221928
AppSec [baseline] (32.496 ms) : 0, 32496
AppSec [candidate] (32.561 ms) : 0, 32561
Debugger [baseline] (13.185 ms) : 0, 13185
Debugger [candidate] (13.232 ms) : 0, 13232
Remote Config [baseline] (719.011 µs) : 0, 719
Remote Config [candidate] (705.918 µs) : 0, 706
Telemetry [baseline] (9.869 ms) : 0, 9869
Telemetry [candidate] (9.856 ms) : 0, 9856
Flare Poller [baseline] (4.11 ms) : 0, 4110
Flare Poller [candidate] (4.176 ms) : 0, 4176
ProfilingAgent [baseline] (109.861 ms) : 0, 109861
ProfilingAgent [candidate] (110.497 ms) : 0, 110497
Profiling [baseline] (110.464 ms) : 0, 110464
Profiling [candidate] (111.101 ms) : 0, 111101
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section baseline
no_agent (4.432 ms) : 4374, 4491
. : milestone, 4432,
iast (9.724 ms) : 9560, 9888
. : milestone, 9724,
iast_FULL (14.103 ms) : 13817, 14388
. : milestone, 14103,
iast_GLOBAL (10.471 ms) : 10285, 10657
. : milestone, 10471,
profiling (9.013 ms) : 8864, 9162
. : milestone, 9013,
tracing (7.638 ms) : 7520, 7755
. : milestone, 7638,
section candidate
no_agent (4.192 ms) : 4145, 4240
. : milestone, 4192,
iast (9.775 ms) : 9612, 9938
. : milestone, 9775,
iast_FULL (14.614 ms) : 14322, 14906
. : milestone, 14614,
iast_GLOBAL (10.889 ms) : 10693, 11085
. : milestone, 10889,
profiling (9.016 ms) : 8876, 9156
. : milestone, 9016,
tracing (7.658 ms) : 7548, 7767
. : milestone, 7658,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section baseline
no_agent (35.948 ms) : 35662, 36233
. : milestone, 35948,
appsec (46.62 ms) : 46211, 47030
. : milestone, 46620,
code_origins (43.502 ms) : 43131, 43874
. : milestone, 43502,
iast (44.857 ms) : 44454, 45259
. : milestone, 44857,
profiling (47.58 ms) : 47107, 48054
. : milestone, 47580,
tracing (41.655 ms) : 41314, 41996
. : milestone, 41655,
section candidate
no_agent (36.283 ms) : 35999, 36566
. : milestone, 36283,
appsec (46.569 ms) : 46158, 46980
. : milestone, 46569,
code_origins (44.572 ms) : 44186, 44959
. : milestone, 44572,
iast (45.426 ms) : 45025, 45827
. : milestone, 45426,
profiling (45.734 ms) : 45323, 46145
. : milestone, 45734,
tracing (43.682 ms) : 43324, 44041
. : milestone, 43682,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (3.644 ms) : 3433, 3855
. : milestone, 3644,
iast (2.197 ms) : 2133, 2260
. : milestone, 2197,
iast_GLOBAL (2.253 ms) : 2190, 2317
. : milestone, 2253,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.027 ms) : 1978, 2077
. : milestone, 2027,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.666 ms) : 3453, 3878
. : milestone, 3666,
iast (2.21 ms) : 2147, 2274
. : milestone, 2210,
iast_GLOBAL (2.261 ms) : 2198, 2325
. : milestone, 2261,
profiling (2.055 ms) : 2003, 2106
. : milestone, 2055,
tracing (2.015 ms) : 1966, 2064
. : milestone, 2015,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6a8ec871a0, baseline=1.55.0-SNAPSHOT~b42a4cb149
dateFormat X
axisFormat %s
section baseline
no_agent (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
appsec (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
iast (18.455 s) : 18455000, 18455000
. : milestone, 18455000,
iast_GLOBAL (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
profiling (15.485 s) : 15485000, 15485000
. : milestone, 15485000,
tracing (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
section candidate
no_agent (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
appsec (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
iast (18.641 s) : 18641000, 18641000
. : milestone, 18641000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
profiling (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
tracing (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
|
PerfectSlayer
approved these changes
Oct 27, 2025
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
💭 thought: It feels there is more behind this change than the PR is showing so it’s a bit tough to review 🥲
So far, if the InstanceStore is still based on a ContextStore, we could have expected they keep the same interface even if its concern is a bit different.
But it completely makes sense to keep them separate too. I guess I will discover the whole point of the change later 😉
Contributor
Author
The original intent behind
So this is primarily cleanup to separate out the different concerns. As for why now - I'm moving things around in this area of the codebase and it's as good a time to do this as any (i.e. leave things better than you find them) |
Contributor
Author
BTW it's not based on ContextStore since #9739 - it's now completely separate |
Note this didn't actually have any impact on what could be put in classInstanceStore, because the generic constraint ended up on a producing method in GenericClassValue and producing methods can only really be limited by 'extends' constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and decouple it from the ContextStore API
Motivation
Lower maintenance cost, allows ContextStore API to evolve separately.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]