Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 3, 2023

What does this PR do?

  • Fix a bug where TEST_BUNDLE was not being exported from packages/dd-trace/src/plugins/util/test.js.
  • Update integration-tests/ci-visibility.spec.js to include tests for test modules.
  • Extract logic to add ITR-related tags to addIntelligentTestRunnerSpanTags

Motivation

  • Fix TEST_BUNDLE bug.
  • Add ITR related tags to test module.
  • Update integration tests.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Overall package size

Self size: 3.74 MB
Deduped: 57.23 MB
No deduping: 63.84 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.1.1 10.9 MB 17.75 MB
@datadog/native-iast-taint-tracking 1.1.0 13.38 MB 13.39 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 1.1.2 2.06 MB 2.08 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #2767 (a568187) into master (e22d438) will decrease coverage by 0.11%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   89.23%   89.12%   -0.11%     
==========================================
  Files         314      313       -1     
  Lines       10867    10814      -53     
  Branches       33       33              
==========================================
- Hits         9697     9638      -59     
- Misses       1170     1176       +6     
Impacted Files Coverage Δ
packages/datadog-plugin-mocha/src/index.js 0.00% <0.00%> (ø)
packages/dd-trace/src/plugins/util/test.js 81.30% <18.18%> (-6.20%) ⬇️
packages/datadog-plugin-jest/src/index.js 94.11% <100.00%> (+0.85%) ⬆️
packages/datadog-shimmer/src/shimmer.js

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

type: 'test_module_end',
status: 'pass',
spanResourceMatch: /^test_module/
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not working because module and session was in the same payload

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2023

Benchmarks

Comparing candidate commit a568187 in PR branch juan-fernandez/fix-bundle-test-module with baseline commit e22d438 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 1199 cases.

@juan-fernandez juan-fernandez marked this pull request as ready for review February 3, 2023 13:26
@juan-fernandez juan-fernandez requested a review from a team as a code owner February 3, 2023 13:26
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan-fernandez juan-fernandez merged commit c06ea16 into master Feb 3, 2023
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-bundle-test-module branch February 3, 2023 15:39
iunanua pushed a commit that referenced this pull request Feb 6, 2023
iunanua pushed a commit that referenced this pull request Feb 6, 2023
This was referenced Feb 6, 2023
iunanua pushed a commit that referenced this pull request Feb 7, 2023
iunanua pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants