-
Notifications
You must be signed in to change notification settings - Fork 349
[SVLS-4148] Inject trace context into AWS Stepfunction executions #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVLS-4148] Inject trace context into AWS Stepfunction executions #4069
Conversation
Overall package sizeSelf size: 6.44 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4069 +/- ##
==========================================
+ Coverage 83.11% 85.06% +1.95%
==========================================
Files 244 247 +3
Lines 10255 10950 +695
Branches 33 33
==========================================
+ Hits 8523 9315 +792
+ Misses 1732 1635 -97 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-04-30 17:17:41 Comparing candidate commit 21971fc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
…function_executions
…function_executions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems localstack supports the step function API - can we have a few E2E tests that check the generated spans' shape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
…function_executions
🚂 MergeQueue This pull request was merged directly. |
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
) Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object. SVLS-4148 Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer. --------- Co-authored-by: Jordi Bertran de Balanda <[email protected]> Co-authored-by: Thomas Hunter II <[email protected]>
What does this PR do?
Adds a plugin for AWS Stepfunctions that injects the datadog trace context into the input parameter of a startExecution or startSyncExecution request, if the input parameter is already a JSON object.
Screenshot of a datadog trace showing a JS lambda function invoking a Step Function.
Motivation
SVLS-4148
Serverless Integrations has added the ability to trace Stepfunction executions, and we want to be able to link Stepfunction executions with upstream traces. We do so by inspecting input._datadog in the Logs to Traces Reducer.
Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!