-
Notifications
You must be signed in to change notification settings - Fork 467
refactor(ipc): more general shared file #15085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ea30e1d to
63ba4f3
Compare
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 233 ± 1 ms. The average import time from base is: 235 ± 1 ms. The import time difference between this PR and base is: -2.15 ± 0.06 ms. Import time breakdownThe following import paths have shrunk:
|
e44cf3f to
d81d1c3
Compare
Performance SLOsComparing candidate refactor/ipc-shared-string-file (77c2023) with baseline main (b2d11f1) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.269µs (SLO: <10.000µs 📉 -57.3%) vs baseline: +0.4% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.1% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 7.063µs (SLO: <10.000µs 📉 -29.4%) vs baseline: 📈 +15.0% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.294µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.528µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.4% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.0% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.839µs (SLO: <10.000µs 📉 -51.6%) vs baseline: +0.6% Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.704µs (SLO: <10.000µs 📉 -63.0%) vs baseline: ~same Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.6% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.580µs (SLO: <10.000µs 📉 -54.2%) vs baseline: ~same Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.377µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.439ms (SLO: <22.300ms -8.3%) vs baseline: -0.1% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.4% Memory: ✅ 64.194MB (SLO: <67.000MB -4.2%) vs baseline: +4.8% ✅ iastTime: ✅ 20.528ms (SLO: <22.250ms -7.7%) vs baseline: +0.6% Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.533ms (SLO: <16.550ms -6.1%) vs baseline: ~same Memory: ✅ 53.901MB (SLO: <54.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.505ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.454ms (SLO: <28.200ms -9.7%) vs baseline: +0.2% Memory: ✅ 67.144MB (SLO: <69.500MB -3.4%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.458ms (SLO: <21.750ms -5.9%) vs baseline: -0.5% Memory: ✅ 66.031MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 22.716ms (SLO: <23.500ms -3.3%) vs baseline: -0.2% Memory: ✅ 67.358MB (SLO: <68.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.294ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.3% Memory: ✅ 66.090MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.615ms (SLO: <17.500ms -5.1%) vs baseline: ~same Memory: ✅ 65.716MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.496ms (SLO: <21.750ms -5.8%) vs baseline: +0.1% Memory: ✅ 71.489MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.489ms (SLO: <19.650ms -5.9%) vs baseline: +0.5% Memory: ✅ 65.991MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.814ms (SLO: <20.100ms -6.4%) vs baseline: +0.2% Memory: ✅ 65.667MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.171ms (SLO: <21.500ms -6.2%) vs baseline: +0.2% Memory: ✅ 66.090MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.262ms (SLO: <22.000ms -7.9%) vs baseline: -0.2% Memory: ✅ 65.991MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.043ms (SLO: <19.850ms -9.1%) vs baseline: -0.1% Memory: ✅ 65.844MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.136ms (SLO: <19.400ms -6.5%) vs baseline: +0.1% Memory: ✅ 66.041MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 18.045ms (SLO: <19.450ms -7.2%) vs baseline: ~same Memory: ✅ 65.647MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.077ms (SLO: <2.300ms -9.7%) vs baseline: ~same Memory: ✅ 52.317MB (SLO: <53.500MB -2.2%) vs baseline: +4.5% ✅ errortracking-enabled-userTime: ✅ 2.069ms (SLO: <2.250ms -8.0%) vs baseline: -0.1% Memory: ✅ 52.357MB (SLO: <53.500MB -2.1%) vs baseline: +4.5% ✅ tracer-enabledTime: ✅ 2.070ms (SLO: <2.300ms -10.0%) vs baseline: -0.2% Memory: ✅ 52.475MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: -0.2% Memory: ✅ 62.212MB (SLO: <65.000MB -4.3%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.631ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 62.265MB (SLO: <65.000MB -4.2%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: +0.3% Memory: ✅ 62.287MB (SLO: <65.000MB -4.2%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 45.333MB (SLO: <47.000MB -3.5%) vs baseline: +5.3% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: +0.3% Memory: ✅ 42.077MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: +0.1% Memory: ✅ 46.542MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +5.5% ✅ resource-renamingTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: -0.4% Memory: ✅ 52.502MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: -0.1% Memory: ✅ 52.413MB (SLO: <53.500MB -2.0%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: +0.1% Memory: ✅ 58.117MB (SLO: <60.000MB -3.1%) vs baseline: +5.0% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.964ms (SLO: <4.200ms -5.6%) vs baseline: +0.4% Memory: ✅ 62.246MB (SLO: <66.000MB -5.7%) vs baseline: +4.8% ✅ iast-enabledTime: ✅ 2.441ms (SLO: <2.800ms 📉 -12.8%) vs baseline: +0.4% Memory: ✅ 59.120MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.056ms (SLO: <2.250ms -8.6%) vs baseline: +0.2% Memory: ✅ 52.593MB (SLO: <54.500MB -3.5%) vs baseline: +4.9%
|
a265925 to
6263716
Compare
BenchmarksBenchmark execution time: 2025-10-31 19:13:16 Comparing candidate commit cee44cb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 559 metrics, 3 unstable metrics. |
We refactor the file queue into a more generic shared string file for IPC that can be used by more components.
6263716 to
d62f8fc
Compare
Description
We refactor the file queue into a more generic shared string file for IPC that can be used by more components.