-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DOCS-12906] Add OP Kafka destination #32203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left you some minor suggestions. I'm going to go ahead and approve
1. **Rate Limit Time Window (secs)**: The time window used for the rate limit option. | ||
- This setting has no effect if the rate limit for events is not set. | ||
- Default is `1 second` if **Rate Limit Events** is set, but **Rate Limit Time Window** is not set. | ||
1. Click **Add Option** to add additional [librdkafka options](#librdkafka-options). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's only one item at each level, I'd consider flattening the first two into one level. Maybe something like: "To add additional librdkafka options, click Add Option and select an option in the dropdown menu:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Updated.
Co-authored-by: Heston Hoffman <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes