Skip to content

Conversation

maycmlee
Copy link
Contributor

What does this PR do? What is the motivation?

  • Adds the Kafka destination doc
  • Moves metrics to shortcodes
  • Adds nav items

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner October 15, 2025 17:49
@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 15, 2025
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Oct 15, 2025
Copy link
Contributor

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left you some minor suggestions. I'm going to go ahead and approve

1. **Rate Limit Time Window (secs)**: The time window used for the rate limit option.
- This setting has no effect if the rate limit for events is not set.
- Default is `1 second` if **Rate Limit Events** is set, but **Rate Limit Time Window** is not set.
1. Click **Add Option** to add additional [librdkafka options](#librdkafka-options).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there's only one item at each level, I'd consider flattening the first two into one level. Maybe something like: "To add additional librdkafka options, click Add Option and select an option in the dropdown menu:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Updated.

@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 17, 2025
@maycmlee maycmlee merged commit d7cef58 into master Oct 17, 2025
17 checks passed
@maycmlee maycmlee deleted the may/op-kafka-destination branch October 17, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants