Add native JDK support for UDS on Java 16+ #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
force-pushed
the
sarahchen6/add-jdk-uds-support-pt2
branch
from
e356aaf to
675dddf
Compare
sarahchen6
force-pushed
the
sarahchen6/add-jdk-uds-support-pt2
branch
2 times, most recently
from
34af4da to
c888794
Compare
sarahchen6
force-pushed
the
sarahchen6/add-jdk-uds-support-pt2
branch
from
c888794 to
619e4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces native JDK support for UDS, which was added in Java 16: https://openjdk.org/jeps/380. This is done by:
enableJdkSocketto enable native JDK support for UDS for compatible versions (Java 16+)NonBlockingStatsDClient,NonBlockingStatsDClientBuilder, andUnixStreamClientChannel.UnixDatagramClientChannelcannot be updated at this time.VersionUtilsfile that parses Java versions.This PR follows DataDog/dd-trace-java#8314, which added native JDK support to
dd-trace-java. With native support, we can reduce third party (i.e.jnr-unixsocket) dependencies.