Shorten jmh task execution time #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Shorten jmh task execution time to a more manageable duration
Motivation:
Current jmh task takes about 4 hours and 18 minutes to complete on my 8 cores/16 threads, 3GHZ machine, because each benchmark composes 5 warmup iterations and 5 measurement iterations, each iteration takes 10s, and each benchmark is executed 5 times.
Long execution time does not necessary result in more accurate numbers, but limits its utilization.
This change shorten the execution time by reducing warmup and measurement iterations to 3, always reducing warmup to 1s per iteration and measurement to 3s per iteration, total execution time down to about 30 minutes.
Additional Notes:
How to test the change?:
Run benchmark with command line:
gradlew jmhFor Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!