APMSP-1930 add retry logic for test setup requests to test agent #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-04-10 13:17:50 Comparing candidate commit 4f6c368 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
- Coverage 71.55% 71.50% -0.05%
==========================================
Files 337 337
Lines 50516 50583 +67
==========================================
+ Hits 36145 36170 +25
- Misses 14371 14413 +42
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
paullegranddc
approved these changes
Apr 10, 2025
| /// # Arguments | ||
| /// | ||
| /// * `req` - A `Request<Body>` representing the HTTP request to be sent. | ||
| /// * `max_retries` - An `i32` specifying the maximum number of retry attempts. |
Contributor
There was a problem hiding this comment.
The name of the parameter also needs to be updated here
Contributor
Author
There was a problem hiding this comment.
good catch, thank you.
ekump
force-pushed
the
ekump/APMSP-1930-add-retry-logic-to-test-agent-requests
branch
from
e9519b5 to
4f6c368
Compare
ekump
deleted the
ekump/APMSP-1930-add-retry-logic-to-test-agent-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It rarely happens, but it is possible for the container running the test agent for integration tests to reset the network connection even after the agent is ready. This PR adds retry logic for the http requests we send to the agent that aren't part of what's actually being tested. Currently that is starting a test session, validating test snapshots, and getting all the traces that the agent has received. This should hopefully fix flakiness where you see an error like
Request failed: hyper_util::client::legacy::Error(SendRequest, hyper::Error(Io, Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }))Motivation
Baklava should be flaky, not our tests
Additional Notes
How to test the change?
I tested the retry logic works by breaking a snapshot and observing that it retried the correct number of times. I don't really know how to test a connection reset by peer scenario easily.