Skip to content

feat(sidecar): add telemetry clients expiration #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 28, 2025
Merged

feat(sidecar): add telemetry clients expiration #1077

merged 15 commits into from
Jul 28, 2025

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented May 28, 2025 •
edited
Loading

What does this PR do?

Reduce telemetry volume sent to be a 30 min interval.

Motivation

Improve performance as well as massively reduce the intake costs for PHP telemetry.

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-07-28 11:02:58

Comparing candidate commit 44a993b in PR branch leiyks-reduce-telemetry-size with baseline commit 9bc0e46 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.645µs 536.495µs ± 0.789µs 536.405µs ± 0.257µs 536.676µs 537.160µs 537.811µs 546.178µs 1.82% 9.377 111.850 0.15% 0.056µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1830904.746op/s 1863955.785op/s ± 2704.050op/s 1864263.521op/s ± 891.764op/s 1865139.293op/s 1865803.356op/s 1866319.563op/s 1866909.760op/s 0.14% -9.264 109.955 0.14% 191.205op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.694µs 381.454µs ± 0.350µs 381.469µs ± 0.231µs 381.661µs 382.113µs 382.321µs 382.575µs 0.29% 0.405 -0.033 0.09% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2613869.978op/s 2621553.216op/s ± 2407.039op/s 2621446.555op/s ± 1587.921op/s 2623276.247op/s 2625277.277op/s 2625779.019op/s 2626781.301op/s 0.20% -0.401 -0.041 0.09% 170.203op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.670µs 195.510µs ± 0.487µs 195.516µs ± 0.454µs 195.910µs 196.173µs 196.441µs 196.519µs 0.51% 0.111 -1.390 0.25% 0.034µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5088576.040op/s 5114866.003op/s ± 12743.017op/s 5114663.357op/s ± 11884.142op/s 5126707.936op/s 5131373.561op/s 5134008.624op/s 5136890.702op/s 0.43% -0.106 -1.393 0.25% 901.067op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.818µs 37.035µs ± 0.130µs 37.046µs ± 0.080µs 37.111µs 37.182µs 37.273µs 38.131µs 2.93% 2.938 23.574 0.35% 0.009µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26225495.553op/s 27001593.381op/s ± 93662.504op/s 26993467.583op/s ± 58065.106op/s 27076698.185op/s 27119782.279op/s 27155372.340op/s 27160289.846op/s 0.62% -2.765 21.747 0.35% 6622.939op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.880µs 46.043µs ± 0.080µs 46.038µs ± 0.050µs 46.089µs 46.174µs 46.225µs 46.519µs 1.04% 1.085 5.115 0.17% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21496704.668op/s 21719055.733op/s ± 37730.264op/s 21721273.758op/s ± 23528.096op/s 21742439.071op/s 21779620.346op/s 21791986.174op/s 21796134.559op/s 0.34% -1.054 4.924 0.17% 2667.933op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.385µs; 536.604µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1863581.029op/s; 1864330.540op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.405µs; 381.502µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2621219.624op/s; 2621886.808op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.442µs; 195.577µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5113099.943op/s; 5116632.063op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.017µs; 37.053µs] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26988612.659op/s; 27014574.104op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.032µs; 46.054µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21713826.681op/s; 21724284.785op/s] or [-0.024%; +0.024%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.576µs 147.268µs ± 0.298µs 147.222µs ± 0.122µs 147.375µs 147.742µs 148.286µs 149.402µs 1.48% 2.303 13.242 0.20% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.227µs; 147.309µs] or [-0.028%; +0.028%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.205ms 8.228ms ± 0.010ms 8.227ms ± 0.006ms 8.233ms 8.244ms 8.262ms 8.269ms 0.51% 1.089 2.365 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.226ms; 8.229ms] or [-0.017%; +0.017%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.087µs 205.925µs ± 0.429µs 205.920µs ± 0.322µs 206.191µs 206.619µs 206.946µs 207.022µs 0.54% 0.221 -0.635 0.21% 0.030µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4830400.714op/s 4856162.645op/s ± 10104.969op/s 4856252.308op/s ± 7579.071op/s 4864725.943op/s 4870969.916op/s 4874008.772op/s 4875973.037op/s 0.41% -0.213 -0.643 0.21% 714.529op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.195µs 18.297µs ± 0.084µs 18.288µs ± 0.045µs 18.324µs 18.474µs 18.534µs 18.669µs 2.08% 1.399 2.477 0.46% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53564106.107op/s 54654526.053op/s ± 249298.496op/s 54680401.098op/s ± 133904.788op/s 54839872.183op/s 54953797.364op/s 54958453.257op/s 54960052.355op/s 0.51% -1.365 2.341 0.45% 17628.066op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.921µs 10.982µs ± 0.030µs 10.976µs ± 0.016µs 10.998µs 11.038µs 11.088µs 11.100µs 1.13% 1.060 2.106 0.27% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90087138.832op/s 91054709.102op/s ± 245255.634op/s 91104193.175op/s ± 133739.082op/s 91205808.155op/s 91408225.789op/s 91555363.321op/s 91563530.523op/s 0.50% -1.036 2.028 0.27% 17342.192op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.865µs; 205.984µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4854762.193op/s; 4857563.096op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.285µs; 18.309µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54619975.679op/s; 54689076.427op/s] or [-0.063%; +0.063%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.978µs; 10.987µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [91020719.030op/s; 91088699.174op/s] or [-0.037%; +0.037%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.121ms 60.621ms ± 2.538ms 60.249ms ± 0.048ms 60.343ms 60.601ms 79.503ms 82.875ms 37.55% 7.821 60.392 4.18% 0.179ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.270ms; 60.973ms] or [-0.580%; +0.580%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.708µs 25.677µs ± 9.797µs 17.992µs ± 0.156µs 34.227µs 42.333µs 51.459µs 71.473µs 297.26% 1.088 1.347 38.06% 0.693µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.319µs; 27.035µs] or [-5.288%; +5.288%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 85.371µs 85.624µs ± 0.209µs 85.596µs ± 0.040µs 85.640µs 85.738µs 85.979µs 88.189µs 3.03% 9.828 114.385 0.24% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [85.595µs; 85.653µs] or [-0.034%; +0.034%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.307µs 2.367µs ± 0.017µs 2.372µs ± 0.008µs 2.377µs 2.385µs 2.388µs 2.391µs 0.80% -1.793 3.609 0.71% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.364µs; 2.369µs] or [-0.098%; +0.098%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.531µs 33.954µs ± 0.684µs 33.638µs ± 0.048µs 33.771µs 35.375µs 35.415µs 37.118µs 10.35% 1.859 2.335 2.01% 0.048µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.859µs; 34.048µs] or [-0.279%; +0.279%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 247.482ns 256.962ns ± 12.874ns 250.901ns ± 2.203ns 257.131ns 291.835ns 296.624ns 304.157ns 21.23% 1.944 2.818 5.00% 0.910ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [255.178ns; 258.746ns] or [-0.694%; +0.694%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.022µs 5.091µs ± 0.038µs 5.099µs ± 0.032µs 5.126µs 5.134µs 5.138µs 5.142µs 0.83% -0.259 -1.600 0.75% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.085µs; 5.096µs] or [-0.104%; +0.104%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.891µs 3.911µs ± 0.004µs 3.911µs ± 0.002µs 3.912µs 3.918µs 3.923µs 3.926µs 0.38% 0.417 6.294 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 254743260.736op/s 255677524.230op/s ± 238994.261op/s 255718756.971op/s ± 114275.966op/s 255817567.359op/s 255932773.417op/s 255992294.315op/s 257011504.004op/s 0.51% -0.394 6.361 0.09% 16899.446op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 78.882µs 80.938µs ± 0.896µs 80.807µs ± 0.611µs 81.591µs 82.473µs 83.104µs 83.719µs 3.60% 0.312 -0.101 1.10% 0.063µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11944751.156op/s 12356685.858op/s ± 136331.741op/s 12375121.987op/s ± 93975.289op/s 12450023.185op/s 12553360.836op/s 12644975.372op/s 12677207.782op/s 2.44% -0.253 -0.160 1.10% 9640.110op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.414µs 74.892µs ± 0.183µs 74.884µs ± 0.097µs 74.989µs 75.184µs 75.402µs 75.985µs 1.47% 1.110 5.984 0.24% 0.013µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13160499.958op/s 13352611.287op/s ± 32511.570op/s 13354014.785op/s ± 17231.712op/s 13370065.093op/s 13403792.404op/s 13426887.877op/s 13438270.852op/s 0.63% -1.061 5.719 0.24% 2298.915op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.890µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.919µs 3.920µs 0.24% -1.210 12.144 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255097512.470op/s 255688396.983op/s ± 192453.229op/s 255713658.285op/s ± 109153.693op/s 255804694.025op/s 255919504.172op/s 255977383.712op/s 257063156.941op/s 0.53% 1.239 12.351 0.08% 13608.498op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.411µs 72.083µs ± 0.190µs 72.056µs ± 0.110µs 72.188µs 72.401µs 72.563µs 72.668µs 0.85% 0.216 0.926 0.26% 0.013µs 1 200
credit_card/is_card_number/378282246310005 throughput 13761164.983op/s 13873068.863op/s ± 36499.685op/s 13878003.365op/s ± 21171.027op/s 13894811.677op/s 13924597.395op/s 13943301.091op/s 14003466.009op/s 0.90% -0.193 0.942 0.26% 2580.917op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.115µs 52.186µs ± 0.028µs 52.182µs ± 0.019µs 52.206µs 52.233µs 52.256µs 52.259µs 0.15% 0.315 -0.402 0.05% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19135570.534op/s 19162382.617op/s ± 10238.671op/s 19163578.661op/s ± 7117.971op/s 19170344.914op/s 19177349.922op/s 19180579.645op/s 19188383.353op/s 0.13% -0.312 -0.404 0.05% 723.983op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.689µs 5.881µs ± 0.077µs 5.893µs ± 0.051µs 5.928µs 5.997µs 6.031µs 6.037µs 2.43% -0.407 -0.068 1.30% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165656400.300op/s 170059752.028op/s ± 2228192.058op/s 169687363.539op/s ± 1463015.935op/s 171552742.081op/s 174107662.496op/s 175662082.003op/s 175766158.050op/s 3.58% 0.476 0.011 1.31% 157556.971op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.911µs ± 0.003µs 3.910µs ± 0.002µs 3.912µs 3.915µs 3.916µs 3.919µs 0.21% -0.507 5.014 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255199400.855op/s 255711753.518op/s ± 168804.147op/s 255726889.694op/s ± 105633.822op/s 255815635.083op/s 255929668.726op/s 255978339.858op/s 256702319.878op/s 0.38% 0.520 5.085 0.07% 11936.256op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.126µs 64.300µs ± 0.086µs 64.281µs ± 0.045µs 64.341µs 64.459µs 64.551µs 64.736µs 0.71% 1.256 2.951 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15447445.661op/s 15552146.810op/s ± 20785.388op/s 15556688.623op/s ± 10801.010op/s 15565233.883op/s 15579455.062op/s 15583285.783op/s 15594311.195op/s 0.24% -1.243 2.885 0.13% 1469.749op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.381µs 57.548µs ± 0.126µs 57.513µs ± 0.066µs 57.594µs 57.779µs 57.945µs 58.230µs 1.25% 1.757 4.819 0.22% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17173269.904op/s 17377028.754op/s ± 37915.010op/s 17387375.896op/s ± 20098.004op/s 17403617.342op/s 17422116.680op/s 17426210.886op/s 17427371.430op/s 0.23% -1.733 4.674 0.22% 2680.996op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.892µs 3.910µs ± 0.003µs 3.910µs ± 0.002µs 3.912µs 3.914µs 3.916µs 3.916µs 0.16% -1.495 11.288 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255333213.838op/s 255732533.858op/s ± 167876.833op/s 255737695.736op/s ± 109958.413op/s 255842869.093op/s 255938962.531op/s 255995757.544op/s 256929329.764op/s 0.47% 1.517 11.465 0.07% 11870.685op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.551µs 54.803µs ± 0.146µs 54.778µs ± 0.082µs 54.861µs 55.086µs 55.244µs 55.507µs 1.33% 1.332 2.886 0.27% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18015855.725op/s 18247152.215op/s ± 48510.513op/s 18255382.932op/s ± 27285.172op/s 18281412.386op/s 18306539.832op/s 18323597.972op/s 18331348.439op/s 0.42% -1.308 2.774 0.27% 3430.211op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.121µs 52.192µs ± 0.035µs 52.190µs ± 0.022µs 52.210µs 52.241µs 52.298µs 52.366µs 0.34% 1.183 3.349 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19096244.375op/s 19160059.178op/s ± 12836.203op/s 19160926.083op/s ± 8125.483op/s 19169322.376op/s 19176987.519op/s 19184164.336op/s 19186101.588op/s 0.13% -1.175 3.314 0.07% 907.657op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.721µs 5.881µs ± 0.071µs 5.892µs ± 0.046µs 5.934µs 5.990µs 6.002µs 6.033µs 2.39% -0.314 -0.591 1.20% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165746402.330op/s 170066154.908op/s ± 2047925.661op/s 169714260.350op/s ± 1331210.032op/s 171553386.071op/s 173668554.242op/s 174701291.297op/s 174793498.095op/s 2.99% 0.361 -0.555 1.20% 144810.212op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ throughput [255644401.924op/s; 255710646.536op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.814µs; 81.062µs] or [-0.153%; +0.153%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12337791.590op/s; 12375580.126op/s] or [-0.153%; +0.153%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.867µs; 74.917µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13348105.496op/s; 13357117.078op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255661724.816op/s; 255715069.149op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.056µs; 72.109µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/378282246310005 throughput [13868010.358op/s; 13878127.368op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.182µs; 52.189µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19160963.636op/s; 19163801.599op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.871µs; 5.892µs] or [-0.181%; +0.181%] None None None
credit_card/is_card_number/x371413321323331 throughput [169750946.039op/s; 170368558.018op/s] or [-0.182%; +0.182%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.910µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255688358.886op/s; 255735148.149op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.288µs; 64.312µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15549266.155op/s; 15555027.465op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.530µs; 57.565µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17371774.098op/s; 17382283.409op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.910µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255709267.744op/s; 255755799.973op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.783µs; 54.824µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18240429.125op/s; 18253875.306op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.187µs; 52.197µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19158280.203op/s; 19161838.152op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.871µs; 5.891µs] or [-0.166%; +0.166%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169782332.107op/s; 170349977.708op/s] or [-0.167%; +0.167%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.856ms 14.901ms ± 0.029ms 14.896ms ± 0.013ms 14.912ms 14.948ms 15.007ms 15.079ms 1.23% 2.328 8.539 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.897ms; 14.905ms] or [-0.027%; +0.027%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44a993b 1753699872 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.199µs 3.293µs ± 1.435µs 3.079µs ± 0.025µs 3.102µs 3.739µs 14.028µs 15.027µs 388.02% 7.320 54.901 43.47% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.094µs; 3.492µs] or [-6.039%; +6.039%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0.80808% with 491 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.12%. Comparing base (9bc0e46) to head (44a993b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   71.21%   71.12%   -0.09%     
==========================================
  Files         348      345       -3     
  Lines       53848    53677     -171     
==========================================
- Hits        38347    38177     -170     
+ Misses      15501    15500       -1
Components Coverage Δ
datadog-crashtracker 43.81% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 86.82% <ø> (ø)
data-pipeline-ffi 88.36% <ø> (ø)
ddcommon 82.99% <ø> (ø)
ddcommon-ffi 70.01% <ø> (ø)
ddtelemetry 60.08% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.68% <ø> (+0.10%) ⬆️
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 38.72% <0.80%> (-1.85%) ⬇️
datdog-sidecar-ffi 19.13% <28.57%> (+0.33%) ⬆️
spawn-worker 55.35% <ø> (ø)
tinybytes 91.59% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.94% <ø> (ø)
datadog-tracer-flare 75.14% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 88e2fff to d0dd988 Compare June 3, 2025 14:07
@r1viollet
Copy link
Contributor

r1viollet commented Jun 3, 2025 •
edited by ekump
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.12 MB 22.12 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.32 MB 70.32 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.24 MB 9.24 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.18 MB 26.18 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 82.55 MB 82.55 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.16 MB 9.16 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.40 MB 18.40 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.03 KB 65.03 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 124.94 MB 124.97 MB +.01% (+24.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 646.92 MB 646.92 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.89 MB 5.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.03 KB 65.03 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.35 MB 17.35 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.19 MB 32.19 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.69 MB 15.69 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.03 KB 66.03 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.33 MB 127.33 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 636.65 MB 636.65 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.49 MB 4.49 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.03 KB 66.03 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.48 MB 18.49 MB +.04% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.23 MB 30.23 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.04 MB 63.04 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.85 MB 9.85 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.97 MB 20.97 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 77.49 MB 77.49 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.75 MB 9.75 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 24.10 MB 24.10 MB 0% (0 B) 👌

bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 4 times, most recently from 8108039 to e69e142 Compare June 17, 2025 13:23
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from e69e142 to 2671326 Compare June 18, 2025 11:35
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 9257c8b to 97e94de Compare June 18, 2025 12:57
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 2 times, most recently from bd0fe85 to 74e40d7 Compare June 18, 2025 14:09
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 2 times, most recently from 2b562ab to 00d1748 Compare July 22, 2025 13:47
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 00d1748 to ec3cde9 Compare July 25, 2025 12:57
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 25, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 44a993b | Was this helpful? Give us feedback!

Leiyks added 15 commits July 28, 2025 12:51
@Leiyks
feat(sidecar): add telemetry clients expiration
bf580ef 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): buffer integrations and dependencies
1921b12 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): replace tokio Mutex by standard one for consistency
54e7635 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): use cached telemetry clients
9210108 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): update TelemetryCachedClient structs
b5cd804 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): clean sidecar server telemetry behaviour
c8b79c7 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): remove unused AppInstance and EnqueuedTelemetryData an…
301b8e7 
…d refacto telemetry

Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): apply feedbacks
2c3fb63 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): expose path_for_telemetry
8480dfe 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: add debug logs
0c8368b 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: fix telemetry lifecycle
aa14549 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: merge telemetry module
af36a66 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat: apply PR suggestions
5071247 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat: remove needs for version
2ffffe2 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar: telemetry): handle config buffering
44a993b 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from ec3cde9 to 44a993b Compare July 28, 2025 10:51
@Leiyks
Copy link
Contributor Author

Leiyks commented Jul 28, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-28 11:48:02 UTC ℹ️ Start processing command /merge

2025-07-28 11:48:08 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 40m (p90).

2025-07-28 12:17:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit de42dc2 into main Jul 28, 2025
46 checks passed
@dd-mergequeue dd-mergequeue bot deleted the leiyks-reduce-telemetry-size branch July 28, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done sidecar

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Leiyks @codecov-commenter @r1viollet @bwoebi