Fix Pagination issue in Postgres table results #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahithvibudhi
approved these changes
Aug 12, 2025
Contributor
sahithvibudhi
left a comment
sahithvibudhi
left a comment
There was a problem hiding this comment.
looks like we have similar code in clickhouse too, can we DRY this code somehow in a follow up PR?
Collaborator
Author
sure! I will open a issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed pagination issue for table results when using PostgreSQL connections. Previously, pagination was not working correctly, causing results pane to show only first 100 rows
Type of Change
Please mark the relevant option(s):
🐛 Bug fix (non-breaking change which fixes an issue)
Please confirm the following:
I have tested these changes locally
Additional Notes
Fixed SQL query generation for OFFSET and LIMIT clauses in PostgreSQL
Improved error handling for pagination edge cases