Skip to content

Conversation

@DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Jun 15, 2024

Description

Collect the top namespace for the package distributions.

Example:
Adding a third-party library that adds features into a sub-namespace, such as "google-cloud-storage".

Importing it in Python: from google import cloud or from google.cloud import storage.

The added feature will locate the top-namespace - i.e. google - based on the details of the package distribution data.

Motivation and Context

This should make the poly check and poly libs more correct, when analyzing and reporting on third-party dependencies, and less need for the --alias option.

Solving issues discussed in #209

How Has This Been Tested?

✅ CI
✅ Unit test
✅ running the third-party libs lookup in the REPL

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidVujic DavidVujic changed the title fix(poly check, poly libs): include package distributions top namespa… feat(poly check, poly libs): include package distributions top namespace for known aliases Jun 15, 2024
@DavidVujic DavidVujic marked this pull request as ready for review June 15, 2024 15:55
@DavidVujic DavidVujic merged commit 127d44f into main Jun 15, 2024
@DavidVujic DavidVujic deleted the better-libs-check branch June 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants