ci: correcting Convention Commit Linter arguments

[DeveloperC286]

No description provided.

[claude]

PR Review: Conventional Commit Linter Argument Fix

Summary

This PR updates the conventional commits linter argument from --allow-angular-type-only to --type angular in the Makefile. This appears to be a correction to align with the linter's current API.

Code Quality & Best Practices ✅

• Clean and focused change: The modification is minimal and targeted
• Consistent with repository conventions: Follows the existing Makefile structure and Docker-based tooling approach
• Proper CI integration: The change maintains compatibility with the existing GitHub Actions workflow

Technical Assessment

Potential Issues ⚠️

• Breaking change risk: Without access to the linter's documentation, it's unclear if this is a breaking change or API update. Consider:
  • Testing the change locally before merging
  • Verifying that --type angular provides equivalent functionality to --allow-angular-type-only

Performance Considerations ✅

• No performance impact: This is a configuration change that doesn't affect runtime performance
• Docker image unchanged: Uses the same linter version, so no container build impact

Security Concerns ✅

• No security implications: The change only affects linting configuration
• Pinned dependencies: The Docker image version remains pinned with SHA hash

Test Coverage

• Manual verification needed: Since this affects CI tooling, the change should be validated by:
  1. Running make check-conventional-commits-linting FROM=origin/main locally
  2. Ensuring the CI workflow passes with the new argument

Recommendations

1. Test locally first: Run the linter with the new argument before merging
2. Document the change: Consider adding a comment explaining why the argument changed (API deprecation, etc.)
3. Monitor CI: Watch the conventional commits workflow on this PR to ensure it passes

Verdict

This appears to be a necessary maintenance update. The change is well-scoped and follows project conventions. ✅ Approved pending successful CI validation.