Cleanup #5
Merged
Cleanup #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes sspi dependency from local to sspi 0.17
- adds clippy rule groups, defined in the workspace Cargo.toml
- reasonable exceptions added to Cargo.toml
- fixes pedantic clippy for all crates
- adds explicit `expect(clippy::foo)` for uncorrected areas, e.g.,
function too long
- minimal logic changes
- some performant improvements from clippy suggestions, e.g.,
`map_or_else` instead of `map_or`
irvingoujAtDevolution
approved these changes
Oct 15, 2025
|
Thanks! Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes sspi dependency from local to sspi 0.17
adds clippy rule groups, defined in the workspace Cargo.toml
fixes pedantic clippy for all crates
expect(clippy::foo)for uncorrected areas, e.g., function too longminimal logic changes
map_or_elseinstead ofmap_orSupersedes Use published sspi version #3 and Fix build #4