Skip to content

fix(sspi): don't split UPNs into username/domain #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sspi): don't split UPNs into username/domain #475

wants to merge 1 commit into from

Conversation

RRRadicalEdward
Copy link
Collaborator

No description provided.

@RRRadicalEdward RRRadicalEdward requested a review from CBenoit July 31, 2025 12:33
@RRRadicalEdward RRRadicalEdward self-assigned this Jul 31, 2025
@RRRadicalEdward
Copy link
Collaborator Author

Hi @CBenoit. Could you have a look?

@RRRadicalEdward
Copy link
Collaborator Author

HI @CBenoit! Did you miss this one, or is there a reason you don't merge it?

@CBenoit
Copy link
Member

CBenoit commented Sep 3, 2025

Hi @CBenoit! Did you miss this one, or is there a reason you don't merge it?

Hi! Thanks for the reminder. I didn’t merge yet because I think the API change may need a slightly different approach. I’d like to explore that direction before merging this as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit Awaiting requested review from CBenoit

At least 1 approving review is required to merge this pull request.

Assignees

@RRRadicalEdward RRRadicalEdward

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RRRadicalEdward @CBenoit