fix!: async network client returns !Send future
#513
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I broke the
dpapi-webcompilation in this PR: #457. I was trying to make theAsyncNetworkClientwork with Devolutions-Gateway, but later I chose another approach. Now we can remove theSendbound safely (I checked it: the DG compiles well with this change insspi-rs).Why haven't we caught it earlier?
I suppose it is because we do not check this crate on CI. I propose improving the
./tools/wasm-testcompileto depend ondpapi-weband use any of its exported items. What do you think about it?