fix Base/Quote currency ordering in global symbol conversion #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One more note - this is likely a breaking change because of how global symbols were treated in some cases. |
vslee
changed the title
Collaborator
|
Anyone have any objections here? |
Collaborator
|
Will defer to you on this one |
jjxtra
approved these changes
Jan 28, 2020
Collaborator
|
@vslee Can we rev to a 0.7.0 version as this is a breaking change? |
Collaborator
|
Yes, I'll set the next nuget version to be 0.7.0. |
Collaborator
|
Thank you! |
szmcdull
pushed a commit
to szmcdull/ExchangeSharp
that referenced
this pull request
Mar 5, 2020
…Ruby#515) * Test and fix base ExhchangeAPI symbol functionality * Fix bitthumb and Kraken APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
Global symbols list the base currency first (e.g. BTC) and quote/conversion currency
second (e.g. USD). Global symbols are of the form BASE-QUOTE. BASE-QUOTE is read as
1 BASE is worth y QUOTE.
Examples:
On 1/25/2020,
- BTC-USD: $8,371; 1 BTC (base) is worth $8,371 USD (quote)
- ETH-BTC: 0.01934; 1 ETH is worth 0.01934 BTC
- EUR-USD: 1.2; 1 EUR worth 1.2 USD
Pull Request Changes: