Async ExchangeAPI init #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vslee
requested changes
Sep 30, 2021
| return GetExchangeAPIAsync<T>().Result; | ||
| } | ||
|
|
||
| public static Task<IExchangeAPI> GetExchangeAPIAsync<T>() where T : ExchangeAPI |
Collaborator
There was a problem hiding this comment.
Can you update the example in README.md to this new method?
vslee
approved these changes
Oct 1, 2021
Collaborator
vslee
left a comment
vslee
left a comment
There was a problem hiding this comment.
This is technically not a "breaking change", since you are using the Obsolete attribute, but I will mark it with the "breaking change" tag to alert ppl to migrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I though would be a quick and easy change escalated rather quickly :) The existing sync methods are marked as obsolete with a hint to use the async ones.
The semaphore in
GetExchangeAPIAsyncis used to make sure initialization is called only onceresolves #666 (😈)