Skip to content

[FTX] Fix OnGetOrderDetailsAsync #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2021
Merged

[FTX] Fix OnGetOrderDetailsAsync #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cc607a
Fix OnGetOrderDetailsAsync
bezysoftware Oct 8, 2021
2ac0005
[FTX] Remove withdrawal tag
bezysoftware Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ protected async override Task<ExchangeOrderBook> OnGetOrderBookAsync(string mark
/// <inheritdoc />
protected async override Task<ExchangeOrderResult> OnGetOrderDetailsAsync(string orderId, string marketSymbol = null, bool isClientOrderId = false)
{ // https://docs.ftx.com/#get-order-status and https://docs.ftx.com/#get-order-status-by-client-id
if (marketSymbol != null) throw new NotImplementedException("Searching by marketSymbol is either not implemented by or supported by this exchange. Please submit a PR if you are interested in this feature");
if (!string.IsNullOrEmpty(marketSymbol)) throw new NotImplementedException("Searching by marketSymbol is either not implemented by or supported by this exchange. Please submit a PR if you are interested in this feature");

var url = "/orders/";
if (isClientOrderId)
Expand Down Expand Up @@ -339,7 +339,6 @@ protected override async Task<ExchangeWithdrawalResponse> OnWithdrawAsync(Exchan
{ "coin", request.Currency },
{ "size", request.Amount },
{ "address", request.Address },
{ "tag", request.AddressTag },
{ "nonce", await GenerateNonceAsync() },
{ "password", request.Password },
{ "code", request.Code }
Expand Down