Skip to content

fix: Binance issue where Fees = null so null += Anything == null #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: Binance issue where Fees = null so null += Anything == null #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@ private static void ParseFees(JToken feesToken, ExchangeOrderResult result)
bool currencySet = false;
foreach (var trade in tradesInOrder)
{
result.Fees ??= 0;
result.Fees += trade["commission"].ConvertInvariant<decimal>();

// TODO: Not sure how to handle commissions in different currencies, for example if you run out of BNB mid-trade
Expand Down Expand Up @@ -1016,6 +1017,7 @@ private static void ParseAveragePriceAndFeesFromFills(ExchangeOrderResult result
currencySet = true;
}

result.Fees ??= 0;
result.Fees += fill["commission"].ConvertInvariant<decimal>();

decimal price = fill["price"].ConvertInvariant<decimal>();
Expand Down