SA1206 firing incorrectly for `required` in C# 11

[stephentoub]

Version:
1.2.0-beta.435

Repro:

internal struct SomeStruct
{
    public required int Prop { get; set; }
}

Expected:
No warnings

Actual:

SA1206: The 'required' modifier should appear before 'public'

[bjornhellander]

I also notice that the code fix bails out and does nothing if applied to an unknown modifier. Would be nice if the analyzer did the same, to avoid these endless false positives as the language evolves. Not a big problem with this particular analyzer, but while someone fixes the false positive I think it would be good if the analyzer could be redesigned at the same time.

[bjornhellander]

I tried to create a unit test case, but fail to make the tested code compile:
error CS1519: Invalid token 'int' in class, record, struct, or interface member declaration

Could for example be because Microsoft.CodeAnalysis.CSharp.Workspaces 4.3.0-1.final doesn't support this syntax, or maybe we need to configure the tested project to use reference assemblies for .net 7.0?

[stephentoub]

doesn't support this syntax

You'll need a really recent build of the C# 11 compiler, e.g. in the last two weeks or so.

[bjornhellander]

The latest code analysis package was from a couple of days ago, but I don't know how recent the actual code is. Let´s wait for the next beta and try again.

[bjornhellander]

I have a fix that I am almost happy with (using version 4.3.0-2.final of Roslyn), except that it causes some tests for 1503, 1519 and 1520 to fail due to changed formatting behaviour in the new Roslyn version. I have confirmed that these regressions happen even if I only update that package, so it's not related to the changes for the new modifier.

All failing tests are called TestCodeFixProviderWithAlternateIndentationAsync and they only fail in the c# 11 test project, which is the one with the new Roslyn version. All tests use the SA1503CodeFixProvider to add missing braces using the method SyntaxFactory.Block().

Xunit.Sdk.TrueException: 'Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
 using System.Diagnostics;
 public class Foo
 {
  public void Bar(int i)
  {
   if (i == 0)
-  {
-   Debug.Assert(true);
-  }
- }
+        {
+            Debug.Assert(true);
+        }
+    }
 }

Expected: True
Actual:   False'

Do you have any insights on this, @sharwell?

[bjornhellander]

On hold until a fix for the formatting is available: dotnet/roslyn#63013

[Brunni]

Are there any news about the required modifier? I get "indention errors" here.

[usausa]

I am also waiting for this issue to be resolved.

[Malgefor]

Any update on this issue?