[WIP] Decomp init for testing work #3412
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elf tests to exit after running in initialization
…_exit_after_self_tests, change the self tests testmod so that its about initialization, this works with a compset with SATM, but hangs -- because nothing stops the run
Conflicts: cime_config/testdefs/testmods_dirs/clm/run_self_tests/shell_commands
…branch Conflicts: cime_config/testdefs/testmods_dirs/clm/run_self_tests/shell_commands
…nd use newunit rather than a hardcoded file unit to make it more robust, it wasn't showing any output before
…urning off ncdio_pio testing for the purposes of decompInit work
…k to make it more obvious what is going on because each task should be similar
… stuff in it when use_noio is TRUE
…readmesh subroutine
… fix some of the endrun msgs
…he subname, create new internal subroutines in decompInit_lnd for allocate, clean, and check errors, move the check errors part to the first thing done
…phases as well as logical functions to do that
…sting_work Conflicts: cime_config/testdefs/testmods_dirs/clm/for_testing_fastsetup_bypassrun/user_nl_clm cime_config/testdefs/testmods_dirs/clm/run_self_tests/user_nl_clm
…ing_work Conflicts: bld/namelist_files/namelist_definition_ctsm.xml src/self_tests/SelfTestDriver.F90
…rom run_self_tests which inherits from it
…ing_work Conflicts: cime_config/testdefs/testmods_dirs/clm/for_testing_fastsetup_bypassrun/user_nl_clm
…sting_work Conflicts: cime_config/testdefs/ExpectedTestFails.xml
…array sizes are set before allocates, initialize some decompMod values to invalid for error checking, add error checking to get_proc_bounds/get_proc_clumps, seperate out allocate for gindex to own allocate method, as it has be be done later after decomp is done, these are all improvements in ESCOMP#3448
…, so a standard non strange test-setup is run in the testlist
…needed now, but could be later
… add error handling of nsegspc, don't check endCohort in get_proc_bounds and get_clump_bounds as doesn't seem to be set
…etup/clean for each DecompInit test, move the decomp_mod_clean to decompMod and use it for the decompInit tests
…bounds can be called later, and add some bypass in the lnd_comp_nuopc cap layer for initialization
… out, and so that the self-tests can run to completion afterwards
…Init_lnd timers to around the calls rather than for the entire subroutine, because the things at the top that may abort will then have a broken timer
…e DecompInit self tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Another branch with testing work on decomp init. This one I plan to bring to b4b-dev sooner than the study branch. But, needs quite a bit of work to get to that point. It also includes work on the other branches.
Specific notes
Contributors other than yourself, if any: John Dennis
CTSM Issues Fixed (include github issue #): General work on #2995
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? Yes, new namelist items
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: a few self-tests so ar