Skip to content

fix(emmylua_doc_cli): generate boolean literal #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix(emmylua_doc_cli): generate boolean literal #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/emmylua_doc_cli/src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pub fn render_const(typ: &LuaType) -> Option<String> {
LuaType::StringConst(s) | LuaType::DocStringConst(s) => {
Some(format!("{:?}", s.to_string()))
}
LuaType::BooleanConst(b) => Some(b.to_string()),
Copy link

@gemini-code-assist gemini-code-assist bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a good addition, but it seems to be incomplete. The LuaType enum also has a DocBooleanConst variant, which should probably be handled here as well, similar to how DocIntegerConst and DocStringConst are handled in the same function.

Suggested change
LuaType::BooleanConst(b) => Some(b.to_string()),
LuaType::BooleanConst(b) | LuaType::DocBooleanConst(b) => Some(b.to_string()),

_ => None,
}
}