Fix the `supply` function in `quantities.py` to impose minimum constraint

[tsmbland]

I've just found why the discrepancy.

1. The sector output, taking the values right out of the market, gives the right values as market information is calculated based on the constrains (so figure on the right is correct).
2. The MCA information, surprisingly and I don't know why, is obtained by recalculating everything. In this line, it limits the supply so it is not higher than the maximum production, but it does not impose any minimum constrain but to fulfil the demand, and therefore the minimum service constrained is not honoured.

In summary, the calculation for the MCAMetric_Supply.csv is wrong - and I would presume that any other calculation that uses this supply function will also be wrong, as no minimum constrains are imposed but to fulfill the demand.

Originally posted by @dalonsoa in #321 (comment)

[tsmbland]

@dalonsoa Are you working on this, or would you like me to look into it?

[ahawkes]

Another high priority issue!

…

________________________________ From: Tom Bland ***@***.***> Sent: Wednesday, June 12, 2024 12:54:57 PM To: EnergySystemsModellingLab/MUSE_OS ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [EnergySystemsModellingLab/MUSE_OS] Fix the `supply` function in `quantities.py` to impose minimum constraint (Issue #335) This email from ***@***.*** originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders list<https://spam.ic.ac.uk/SpamConsole/Senders.aspx> to disable email stamping for this address. @dalonsoa<https://github.com/dalonsoa> Are you working on this, or would you like me to look into it? — Reply to this email directly, view it on GitHub<#335 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC37JLIGORIHSE52OSEVK5DZHAZJDAVCNFSM6AAAAABJGGIT4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSHAYTQNRSGY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dalonsoa]

@tsmbland , nope, so all yours!

[dalonsoa]

So, I've been looking into this and, after digging in the exciting world of decorators and registries, it turns out this function is used whenever dispatch_production = 'share' is chosen for a sector, which is most of the times. So:

1. We cannot simply get rid of this function.
2. The function has been doing things wrong all along, as it does not respect the minimum service factor.

So the fix passes through updating the function such that we also calculate a minimum_production and impose it here.