Skip to content

Conversation

@TinyMarsh
Copy link
Contributor

@TinyMarsh TinyMarsh commented May 19, 2023

Description

This PR addresses #105 updating the pyproject.toml file to include the Python versions which were included in the CI workflow in #119 . Specifically, the valid versions that MUSE can now be installed in are 3.8 and 3.9.

Closes #105

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python setup.py build_sphinx

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@dalonsoa dalonsoa linked an issue May 22, 2023 that may be closed by this pull request
@dalonsoa
Copy link
Collaborator

This QA is facing but because of something to change in #118 , so nothing to do here until that is sorted.

@jamesturner246 , let @TinyMarsh know when you're done with that one so he can rebase.

@jamesturner246
Copy link
Contributor

@TinyMarsh @dalonsoa fixed in #118. Was just commas and whitespace fuss.

@TinyMarsh TinyMarsh force-pushed the pyproject_python_versions branch from 0b69bae to 6dab36c Compare May 22, 2023 14:48
@TinyMarsh
Copy link
Contributor Author

I prematurely rebased. It seems I should wait until #118 is merged before rebasing this branch.

@dalonsoa
Copy link
Collaborator

#118 Merged! All yours!

@TinyMarsh
Copy link
Contributor Author

@dalonsoa Rebased and ready for review.

@dalonsoa dalonsoa merged commit 90cf501 into EnergySystemsModellingLab:develop_imperial May 23, 2023
@dalonsoa dalonsoa deleted the pyproject_python_versions branch May 23, 2023 04:16
@dalonsoa dalonsoa mentioned this pull request May 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate valid Python versions in pyproject.toml

3 participants