Skip to content

Conversation

@tsmbland
Copy link
Collaborator

@tsmbland tsmbland commented Jun 26, 2024

Description

Level is included as a parameter in the Technodata files, but this parameter isn't actually used anywhere in the model, so can be removed.

The Level parameter in the CommIn and CommOut files is used, so this stays, although I'm still trying to figure out what this does and will brush up the documentation in a separate PR.

Fixes # (issue)

Type of change

Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.39%. Comparing base (e09a23d) to head (33b5d43).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #374   +/-   ##
========================================
  Coverage    71.39%   71.39%           
========================================
  Files           44       44           
  Lines         5887     5887           
  Branches      1162     1162           
========================================
  Hits          4203     4203           
  Misses        1364     1364           
  Partials       320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmbland tsmbland marked this pull request as ready for review June 26, 2024 09:27
@tsmbland tsmbland requested review from alexdewar and dalonsoa June 26, 2024 09:27
@tsmbland tsmbland self-assigned this Jun 26, 2024
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was used by some obscure, never finally implemented neither documented functionality...

@tsmbland tsmbland merged commit a2a1b4f into develop Jun 26, 2024
@tsmbland tsmbland deleted the level_parameter branch June 26, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants