Skip to content

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Aug 17, 2025

Fix #198, fix #1559.

@avik-pal avik-pal force-pushed the ap/persistent_compile_cache branch from 3d360d4 to df203de Compare August 18, 2025 23:16
Base automatically changed from ap/persistent_compile_cache to main August 19, 2025 04:46
@avik-pal avik-pal force-pushed the wsmoses-patch-7 branch 2 times, most recently from d33fb73 to f6a57b3 Compare August 20, 2025 03:25
wsmoses and others added 2 commits August 19, 2025 23:38
Update CI.yml
Update Project.toml
mem issue fix
@gbaraldi
Copy link

i'm not super aware of what this is doing. But preserving random pointers will not do anything. Preserves are for the julia object that gets turned into a pointer.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 42.50%. Comparing base (6a7c6a4) to head (263bb0c).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
ext/ReactantCUDAExt.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   42.07%   42.50%   +0.43%     
==========================================
  Files         123      123              
  Lines       21621    21807     +186     
==========================================
+ Hits         9096     9269     +173     
- Misses      12525    12538      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wsmoses and others added 2 commits August 29, 2025 11:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wsmoses wsmoses merged commit 27565b4 into main Aug 29, 2025
73 of 74 checks passed
@wsmoses wsmoses deleted the wsmoses-patch-7 branch August 29, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompilation issue on windows (no gpu) Error when precompiling in Windows
3 participants