Handle non-json http error responses and use requests.exceptions.JSONDecodeError instead of json.JSONDecodeError #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests has attempted to consolidate json decoding errors in psf/requests#5856 which was released in requests==2.27.0. Since this project is requests>=2.31.0 we are safe to incorporate the change.
prsutherland
added a commit
to prsutherland/EODHD-APIs-Python-Financial-Library
that referenced
this pull request
Feb 4, 2025
Handle non-json http error responses and use requests.exceptions.JSONDecodeError instead of json.JSONDecodeError EodHistoricalData#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests has attempted to consolidate json decoding errors in psf/requests#5856 which was released in requests==2.27.0. Since this project is requests>=2.31.0 we are safe to incorporate the change.
eodhd.com returns a text/html response for
api.get_bonds_fundamentals_dataif you are using a non-fundamentals api key.