Skip to content

Conversation

craighillwood
Copy link
Contributor

Problem

  1. getMyUserIdx always returns -1
  2. Unnecessary use of /#

Solution

  1. Remove /# from the if statement as the array users contains the socket ids without /#
  2. Remove /# from any other place so it doesn't cause confusion due that the issue was solved by socket.io stop prepend /# before id when no namespace socketio/socket.io#2509

Comments

The /# was something introduced in version 1.4.0 of socket.io as stated here socketio/socket.io#2405

Copy link

@PeterAltamirano PeterAltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good to merge

Copy link

@PeterAltamirano PeterAltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can you update the comment sections?

Copy link

@PeterAltamirano PeterAltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto!

@craighillwood craighillwood merged commit d62bb26 into master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants