chore: redis v2 component #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroDojkic
reviewed
Oct 9, 2025
eLivaja
reviewed
Oct 10, 2025
eLivaja
reviewed
Oct 10, 2025
MiroDojkic
reviewed
Oct 14, 2025
MiroDojkic
reviewed
Oct 14, 2025
Member
MiroDojkic
left a comment
MiroDojkic
left a comment
There was a problem hiding this comment.
Good work!
I see an opportunity for this to be two PRs - please try to reduce PR size in the future.
MiroDojkic
approved these changes
Oct 17, 2025
Member
MiroDojkic
left a comment
MiroDojkic
left a comment
There was a problem hiding this comment.
@droguljic I'll merge this to integrate it asap, but please review when you have time.
droguljic
reviewed
Oct 17, 2025
| export class UpstashRedis extends pulumi.ComponentResource { | ||
| instance: upstash.RedisDatabase; | ||
| password: Password; | ||
| username = 'default'; |
Contributor
There was a problem hiding this comment.
Is this needed? Where is it used?
|
|
||
| describe('EcsService component deployment', () => { | ||
| const region = process.env.AWS_REGION || 'us-east-2'; | ||
| const region = process.env.AWS_REGION; |
Contributor
There was a problem hiding this comment.
What is the reason behind removing the default?
Member
There was a problem hiding this comment.
My comment in the first code review. 👀
| const ecsServiceWithStorage = ctx.outputs.ecsServiceWithStorage.value; | ||
| const clusterName = ctx.outputs.cluster.value.name; | ||
| const region = process.env.AWS_REGION || 'us-east-2'; | ||
| const region = process.env.AWS_REGION; |
Contributor
There was a problem hiding this comment.
What is the reason behind removing the default?
|
|
||
| describe('Web server component deployment', () => { | ||
| const region = process.env.AWS_REGION || 'us-east-2'; | ||
| const region = process.env.AWS_REGION; |
Contributor
There was a problem hiding this comment.
What is the reason behind removing the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate Redis components for AWS ElastiCache and Upstash. No shared base class since there's minimal common logic between them.
Changes:
UPSTASH_EMAILandUPSTASH_API_KEYenvironment variables