Skip to content

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Aug 14, 2021

Partially addresses #142.
Move uuv_mating package out of legacy/, into new repo structure after 4.0.0.

Corresponding tutorial:
https://github.com/Field-Robotics-Lab/dave/wiki/Electrical-Plug-Mating-Plugin

To test the PR, instead of the command in the tutorial, use the new package name:

roslaunch dave_demo_launch uuv_dave_electrical_mate.launch

(TODO(mabelzhang): Update the command in the tutorial once this PR is merged.) Done.

Double-check that the plug object model displays on the square plate, and that the yellow socket model displays near the top of the control panel. See sample images in the tutorial for what they look like.

Feedback needed:
Are the new file names okay? I don’t know enough about the convention in this repo to determine whether the launch files should keep the uuv_dave prefix.

@mabelzhang mabelzhang requested review from M1chaelM and crvogt August 14, 2021 09:48
@mabelzhang mabelzhang requested review from bsb808 and removed request for M1chaelM, crvogt and woensug-choi September 1, 2021 23:12
@bsb808 bsb808 self-assigned this Sep 2, 2021
@bsb808
Copy link
Contributor

bsb808 commented Sep 2, 2021

First - as for naming, since you asked, I find adding the uuv_dave prefix to be redundant to the scoping done in the package name. Recommend changing the launch file name to just electrical_mate.launch.

@bsb808
Copy link
Contributor

bsb808 commented Sep 2, 2021

When I run the example, I get these failed nodes...

WARNING: RDRND generated: 0xffffffff 0xffffffff 0xffffffff 0xffffffff
[rexrov/oberon7/gripper_controller_oberon7-15] process has died [pid 10294, exit code 1, cmd /home/bsb/uuv_ws/devel/lib/uuv_manipulators_control/gripper_controller.py joy:=/rexrov/joy __name:=gripper_controller_oberon7 __log:=/home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-gripper_controller_oberon7-15.log].
log file: /home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-gripper_controller_oberon7-15*.log
[rexrov/oberon7/kinematics_service-16] process has died [pid 10315, exit code 1, cmd /home/bsb/uuv_ws/devel/lib/uuv_manipulators_kinematics/kinematics_service.py __name:=kinematics_service __log:=/home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-kinematics_service-16.log].
log file: /home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-kinematics_service-16*.log
[rexrov/oberon7/joint_position_controller_oberon7-17] process has died [pid 10331, exit code 1, cmd /home/bsb/uuv_ws/devel/lib/uuv_manipulators_control/joint_position_controller.py joy:=/rexrov/joy __name:=joint_position_controller_oberon7 __log:=/home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-joint_position_controller_oberon7-17.log].
log file: /home/bsb/.ros/log/6b7d5964-0c05-11ec-8635-0242ac110002/rexrov-oberon7-joint_position_controller_oberon7-17*.log
starting AccelerationControl.py
starting VelocityControl.py

The culprit(s) seem to be in the uuv_manipulators repo. I'm tracking them down and intend to submit a PR for that repo. Running on the master branch with [email protected]:field-robotics-lab/uuv_manipulators

== Question ==

@mabelzhang - do you see the same error when using the current master branch of the uuv_manipulators repo?

== Fix ==

Here is a small PR that fixes the error for me: Field-Robotics-Lab/uuv_manipulators#6

Once we merge this uuv_manipulators PR and verify, then I'm good to approve.

Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang
Copy link
Contributor Author

Apparently I had an outdated version of this repo and didn't encounter the uuv_manipulators error! Thank you for the fix.

Okay, for consistency, I renamed the launch file and world file to dave_*, since all the other files in those directories start with a dave_ prefix. If we want to remove the redundant dave_, we should rename all of them in a new PR.

Copy link
Contributor

@bsb808 bsb808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@mabelzhang mabelzhang merged commit 6dbbfb9 into master Sep 3, 2021
@mabelzhang mabelzhang deleted the mabelzhang/move_manip_out_of_legacy branch September 3, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants