-
Notifications
You must be signed in to change notification settings - Fork 80
Move uuv_mating out of legacy #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
…in legacy Signed-off-by: Mabel Zhang <[email protected]>
First - as for naming, since you asked, I find adding the |
When I run the example, I get these failed nodes...
The culprit(s) seem to be in the uuv_manipulators repo. I'm tracking them down and intend to submit a PR for that repo. Running on the == Question == @mabelzhang - do you see the same error when using the current master branch of the uuv_manipulators repo? == Fix == Here is a small PR that fixes the error for me: Field-Robotics-Lab/uuv_manipulators#6 Once we merge this uuv_manipulators PR and verify, then I'm good to approve. |
Signed-off-by: Mabel Zhang <[email protected]>
Apparently I had an outdated version of this repo and didn't encounter the uuv_manipulators error! Thank you for the fix. Okay, for consistency, I renamed the launch file and world file to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
Partially addresses #142.
Move
uuv_mating
package out oflegacy/
, into new repo structure after 4.0.0.Corresponding tutorial:
https://github.com/Field-Robotics-Lab/dave/wiki/Electrical-Plug-Mating-Plugin
To test the PR, instead of the command in the tutorial, use the new package name:
(TODO(mabelzhang): Update the command in the tutorial once this PR is merged.)Done.Double-check that the plug object model displays on the square plate, and that the yellow socket model displays near the top of the control panel. See sample images in the tutorial for what they look like.
Feedback needed:
Are the new file names okay? I don’t know enough about the convention in this repo to determine whether the launch files should keep the
uuv_dave
prefix.