Skip to content

Conversation

mabelzhang
Copy link
Contributor

Trying to fix CI broken in #239 and #250
See #250 (comment) and subsequent comments.

CI might be failing because moveit_planners doesn't exist in the Docker image. These ones exist though: moveit_planners_ompl (already a dependency) and moveit_planners_chomp.
Replace moveit_planners with moveit_planners_chomp to see if that fixes CI.

Rearrange in alphabetical order while I'm at it.

@j-herman
Copy link
Contributor

Tested with the dual arm rviz demo and everything still runs fine. If this fixes CI I'll approve for you. It does make me wonder, though, why the other fix worked when moveit_planners was still included in the file.

Copy link
Contributor

@j-herman j-herman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it all still works with the bimanual manipulation demo

@mabelzhang mabelzhang merged commit fa0fb8b into master Mar 25, 2022
@mabelzhang mabelzhang deleted the mabelzhang/fix_moveit_planners_dep branch March 25, 2022 23:47
@mabelzhang
Copy link
Contributor Author

I don't know what the CI is checking, but seems like it's doing more than our manual builds.
It could be that our manual builds aren't running into problems because it's a runtime dependency. Then at runtime, maybe the _ompl package is enough, and _chomp isn't really needed. I don't know.
Either way, moveit_planners seems to be a meta package that has runtime dependency on both _ompl and _chomp, so depending on that should work, except we don't have that package in our Docker image for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants