-
-
Notifications
You must be signed in to change notification settings - Fork 448
Merge Explorer & Everything Plugins #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thinking about enumeration design. Probably it would be better to only use index search when doing recursive search for enumerating a directory, and do a direct search when only traverse the first level. @jjw24 what do you think |
I think directory recursive search with Windows Search could be restricted by user's indexing options/excluded directories, so allowing an option to use DirectoryInfo search method is preferred per current design in this area. What do you mean by direct search when only traverse the first leve? |
oh I mean we may always use the DirectoryInfo Search for the non-recursive traversal. |
@onesounds mind creating a engine selection ui for this? I am not sure whether it is a good practice to use interface for purpose selection, but probably we can adjust that easier.
|
1. Shared Interface for Windows Index and Everything Index 2. Settings Merge (Part 1) 3. Include Everything dll
@Flow-Launcher/team I have almost finished most features and the UI Refactor. There're some small features in everything plugin that I haven't ported, but it will be fairly easy to do so. Anyone want to give this pr a check? |
Changing action keywords do not take effect on first try. Repro: |
@taooceros I am fixing 2,3,4 |
the concurrency bug is ....very weird but interesting (I know what's causing it, and try to find a good solution). |
#1502
TODO: