Skip to content

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Mar 25, 2022

#1502

  1. Shared Interface for Windows Index and Everything Index
  2. Settings Merge (Part 1)
  3. Include Everything dll

TODO:

@taooceros taooceros self-assigned this Mar 26, 2022
@taooceros
Copy link
Member Author

Thinking about enumeration design. Probably it would be better to only use index search when doing recursive search for enumerating a directory, and do a direct search when only traverse the first level. @jjw24 what do you think

@jjw24
Copy link
Member

jjw24 commented Mar 31, 2022

I think directory recursive search with Windows Search could be restricted by user's indexing options/excluded directories, so allowing an option to use DirectoryInfo search method is preferred per current design in this area.

What do you mean by direct search when only traverse the first leve?

@github-actions github-actions bot added the Stale label May 13, 2022
@taooceros taooceros added enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin External Plugin External plugin not included with Flow Launcher and removed Stale labels May 15, 2022
@taooceros
Copy link
Member Author

I think directory recursive search with Windows Search could be restricted by user's indexing options/excluded directories, so allowing an option to use DirectoryInfo search method is preferred per current design in this area.

What do you mean by direct search when only traverse the first leve?

oh I mean we may always use the DirectoryInfo Search for the non-recursive traversal.

@taooceros taooceros marked this pull request as ready for review May 15, 2022 20:21
@taooceros
Copy link
Member Author

@onesounds mind creating a engine selection ui for this? I am not sure whether it is a good practice to use interface for purpose selection, but probably we can adjust that easier.

  • IndexSearchEngine
    • WindowsIndex
    • Everything
  • ContentSearchEngine
    • WindowsIndex
    • Everything
  • PathEnumerator
    • Direct
    • WindowsIndex
    • Everything

@github-actions github-actions bot added the Stale label Jun 21, 2022
1. Shared Interface for Windows Index and Everything Index
2. Settings Merge (Part 1)
3. Include Everything dll
@taooceros taooceros changed the title Merge Explorer & Everything Plugins (Step 1) Merge Explorer & Everything Plugins Jul 4, 2022
@taooceros
Copy link
Member Author

@Flow-Launcher/team I have almost finished most features and the UI Refactor. There're some small features in everything plugin that I haven't ported, but it will be fairly easy to do so. Anyone want to give this pr a check?

@jjw24
Copy link
Member

jjw24 commented Nov 29, 2022

Changing action keywords do not take effect on first try. Repro:
Remove the settings.json file in user data directory. Start up flow, go to Explorer and change Path action keyword. Trigger the keyword and it does not happen. Only after changing the action keyword again then it will trigger.

@jjw24
Copy link
Member

jjw24 commented Nov 30, 2022

Please address:

  1. When Everything is selected as Index Search Engine, press and hold any key will cause below error:
    image

  2. Bring this message back when Windows Index is disabled:
    image

  3. Hide the search window when the prompt to install Everything is shown:
    image

  4. Please add icon for this result:
    image

@jjw24
Copy link
Member

jjw24 commented Dec 1, 2022

Please address:

  1. When Everything is selected as Index Search Engine, press and hold any key will cause below error:
    image
  2. Bring this message back when Windows Index is disabled:
    image
  3. Hide the search window when the prompt to install Everything is shown:
    image
  4. Please add icon for this result:
    image

@taooceros I am fixing 2,3,4

@taooceros
Copy link
Member Author

taooceros commented Dec 3, 2022

the concurrency bug is ....very weird but interesting (I know what's causing it, and try to find a good solution).
Basically the Wait is cancelled so the semaphore count is not reduced, but the finally block release it.

@jjw24 jjw24 enabled auto-merge December 4, 2022 22:30
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Dec 4, 2022
@jjw24 jjw24 merged commit c56a275 into dev Dec 4, 2022
@jjw24 jjw24 deleted the explorerMerge branch December 4, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin External Plugin External plugin not included with Flow Launcher

Projects

Archived in project

5 participants