Skip to content

Conversation

Garulf
Copy link
Member

@Garulf Garulf commented Apr 10, 2022

Trailing whitespace can be very helpful for argument detection.

This PR removes any whitespace trimming from Query before being passed to the Plugin.

@Garulf Garulf added the enhancement New feature or request label Apr 10, 2022
@Garulf Garulf self-assigned this Apr 10, 2022
@taooceros
Copy link
Member

I would say that we still need to trim start since it would be weird to use space as one of the action keyword?

@Garulf
Copy link
Member Author

Garulf commented Apr 10, 2022

I would say that we still need to trim start since it would be weird to use space as one of the action keyword?

No worries the keyword is captured by the line below and is unaffected by this change:

string possibleActionKeyword = terms[0];

@github-actions github-actions bot added the Stale label May 12, 2022
@taooceros taooceros added this to the 1.10.0 milestone May 31, 2022
@taooceros taooceros removed the Stale label Jun 5, 2022
@taooceros taooceros changed the title Pass query without trimming whitespace to JsonRPC Pass query without trimming ending whitespace Jun 5, 2022
@taooceros taooceros changed the title Pass query without trimming ending whitespace Pass query without trimming whitespace Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants