Skip to content

Preview Panel #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 90 commits into from
Dec 7, 2022
Merged

Preview Panel #1360

merged 90 commits into from
Dec 7, 2022

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Sep 2, 2022 •
edited
Loading

Features

  • Preview toggle (F1 Key) for image/full file path display.
  • Option for always on preview. (if turn off, not showing preview when open query bar) Default is off. (for Simple design impression)
  • Adjust Themes for Preview
  • Video/Image/Music file show large preview, others will showing small icon (need plugin update to support)

Sub Features

  • Recover Darker theme
  • Adjust Loading Image

Testcase

  • F1 should not work when empty query state.
  • Always Preview option (general in setting) should work when start flow.
  • Be visible in all width sizes / Themes
  • Works well any last query mode.
  • Glyph Icon should display with glyph mode
  • video/image file should large (max width), others should display small size (96x96)
  • Memory
  • Loading Icon should be gray round box, Files without icons are the same as before.
  • UWP apps icon should be 96x96 / transparency
  • media (jpg, gif, png, avi, mp4, wmv...) preview should be display large image
  • The media file should display normal regardless of the case of the extension. (e.g .gif/GIF)

Future Plans

  • Add High res Icons
  • Add File Type information
  • Customizable Preview hotkey
  • Customizable File Types
  • Click to Copy location or file name
  • LadUpdated/DateAdded/LastUsed info
  • Small Buttons
  • Custom Preview Area for plugins

@onesounds onesounds added the enhancement New feature or request label Sep 2, 2022
@onesounds onesounds self-assigned this Sep 2, 2022
@jjw24
Copy link
Member

jjw24 commented Sep 15, 2022

@onesounds @Garulf Is this ready or still waiting on the todos?

@onesounds
Copy link
Contributor Author

yep still in progress. it need video thumb / customcontrol panel for plugins

@jjw24 jjw24 marked this pull request as draft September 15, 2022 12:31
@jjw24 jjw24 added this to the 1.10.0 milestone Sep 15, 2022
@jjw24 jjw24 added the kind/ui related to UI, icons, themes, etc label Sep 15, 2022
@onesounds
Copy link
Contributor Author

This PR is dirty because I tried many things. (webview, videothumb, opengraph...)
In now. it's not good to merge/reviewing. I'll organize(with rollback) code or I'll make new PR when I get free time.

VictoriousRaptor and others added 22 commits November 29, 2022 19:26
@VictoriousRaptor
Separate image loading logic
aeb72d2 
1. Separate image loading logic
2. Make IconDelegate async while calling to avoid blocking UI thread
@VictoriousRaptor
update description
19d29e8
@onesounds
Merge branch 'dev' into ImagePreview
f548310
@onesounds
Merge Dev
bf9b464
@VictoriousRaptor
Set preview image for uwp apps
564721b
@VictoriousRaptor
Merge branch 'dev' into ImagePreview
e2a46ed
@VictoriousRaptor
fix unnecessary using
ccab608
@VictoriousRaptor
Merge branch 'ImagePreview' of https://github.com/onesounds/Flow.Laun…
ce2948e 
…cher into pr/1360
@VictoriousRaptor
Preview image for explorer
2194e3c
@VictoriousRaptor
Renaming method and property
53b1781
@VictoriousRaptor
refactor preview info
6c54ad8
@onesounds
Merge branch 'dev' into ImagePreview
fa84f44
@onesounds
Adjust Preview Area Heights
89b5242
@onesounds
Fix Reserved Glyph Area
4c846e2
@onesounds
Adjust Preview area Size / Add Source Resize Logic
075a1a3
@VictoriousRaptor
Merge branch 'ImagePreview' of https://github.com/onesounds/Flow.Laun…
05dca1a 
…cher into pr/1360
@onesounds
- Changed UWP preview target image
46f8d42
@onesounds
Merge branch 'ImagePreview' of https://github.com/onesounds/Flow.Laun…
d52496b 
…cher into ImagePreview
@onesounds
Adjust non-media icon sizes
fd395c1
@VictoriousRaptor
Fix file extension case sensitive issue
f509f56
@VictoriousRaptor
revert
219ca53
@VictoriousRaptor
Use square44x44logo for preview to avoid big margin
0231c32
@jjw24 jjw24 marked this pull request as ready for review December 7, 2022 08:39
jjw24
jjw24 reviewed Dec 7, 2022
View reviewed changes
Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
Comment on lines +275 to +287
public static bool IsMedia(string extension)
{
if (string.IsNullOrEmpty(extension))
{
return false;
}
else
{
return MediaExtensions.Contains(extension.ToLowerInvariant());
}
}

public static readonly string[] MediaExtensions = { ".jpg", ".png", ".avi", ".mkv", ".bmp", ".gif", ".wmv", ".mp3", ".flac", ".mp4" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taooceros @VictoriousRaptor I think this is probably better moved to the plugin project, the idea is that plugin does not need to determine and provide whether the result path is a media or not and let Flow determine it, i.e. flow controls whether to display large preview image.

Let me know what you think, we can update it next round.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. but plugin should still have control to whether to use large preview. programs should use small preview. just move this function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think if plugin does not specify anything, flow will work out if it's media and size accordingly by default.

@jjw24 jjw24 merged commit 3dda618 into Flow-Launcher:dev Dec 7, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VictoriousRaptor VictoriousRaptor VictoriousRaptor left review comments

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels

enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

Work In Progress
Archived in project

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onesounds @jjw24 @VictoriousRaptor @Garulf @taooceros