Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Sep 28, 2022

What's the PR

Before
image

After
image

Checklist

  • There should be no impact on other language.
  • It will use the default OS font, so I think there will be no problem.

@onesounds onesounds self-assigned this Sep 28, 2022
@onesounds onesounds added the bug Something isn't working label Sep 28, 2022
@VictoriousRaptor
Copy link
Contributor

VictoriousRaptor commented Sep 28, 2022

Segoe UI is not only used in tabmenu but also elsewhere. Please fix them as well (if you are busy I can do this later, I have to sleep now:( ). i ve tested that it also affects Japanese, maybe Korean as well. sorry I can't tell whether it looks good or bad in Japanese.

@VictoriousRaptor
Copy link
Contributor

VictoriousRaptor commented Sep 28, 2022

BTW it should affect English texts on non-english locale systems. English texts in system default font on non-english systems, like Chinese, is slightly different from Segoe UI.

I think it doesn't matter cuz most people will choose their system language.

@onesounds
Copy link
Contributor Author

When I checked, there were no more cases where Segoe UI was designated.
I checked the other Asian fonts, and it was not a problem.

If you know how to, Do as you wish.

@VictoriousRaptor
Copy link
Contributor

When I checked, there were no more cases where Segoe UI was designated. I checked the other Asian fonts, and it was not a problem.

If you know how to, Do as you wish.

There are some cases in plugins. I've created a PR to your fork.

BTW it should affect English texts on non-english locale systems. English texts in system default font on non-english systems, like Chinese, is slightly different from Segoe UI.

This is because there is no semibold weight in default Chinese font (MS YaHei UI).

@onesounds onesounds changed the title Remove font-family style in tabmenu Remove font-family style Sep 29, 2022
@onesounds
Copy link
Contributor Author

onesounds commented Sep 29, 2022

I missed the plugins. thanks.

BTW it should affect English texts on non-english locale systems. English texts in system default font on non-english systems, like Chinese, is slightly different from Segoe UI.

I checked it after changing OS to another language. It didn't seem particularly problematic. It doesn't have to be Segoe UI.

@onesounds onesounds changed the title Remove font-family style Remove font-family style for Chinese Sep 29, 2022
@onesounds onesounds merged commit 54ded84 into Flow-Launcher:dev Sep 29, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants