Skip to content

Drag and drop #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 7, 2022
Merged

Drag and drop #1428

merged 16 commits into from
Nov 7, 2022

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Sep 28, 2022 •
edited by jjw24
Loading

What's the PR

  • Change result items to draggable (to Desktop or Discord...)
  • How it is dragged depends on the target, e.g. Windows Explorer or other file managers:
    • For Windows Explorer (Win 11), copy: Ctrl+Drag
    • For Windows Explorer (Win 11), move: Drag

Test case

  • Files must be moved and copied to the target location
  • It should be applied where drag attachments are allowed, such as Discord.
  • If it is not a file or folder, it should not be draggable.

Todo list

  • Check the UX (just drag to copy is better? in this case, move by shift+drag)
  • Clean Code
  • Should the file's moved status be updated to the index immediately?

@onesounds onesounds self-assigned this Sep 28, 2022
@onesounds onesounds added the enhancement New feature or request label Sep 28, 2022
@onesounds
Copy link
Contributor Author

onesounds commented Sep 29, 2022 •
edited
Loading

Changed the UX

  • Drag : Copy
  • Shift+Drag : Move

@jjw24 jjw24 marked this pull request as draft October 5, 2022 10:18
@jjw24
Copy link
Member

jjw24 commented Oct 5, 2022 •
edited
Loading

Should the file's moved status be updated to the index immediately

This will be automatic as Explorer's Windows Search and Everything's service should both index the new location, with the exception if Explorer's Window Search is not configured to index the new location.

@taooceros taooceros marked this pull request as ready for review October 30, 2022 15:48
@taooceros taooceros requested a review from jjw24 October 30, 2022 16:35
jjw24
jjw24 reviewed Nov 6, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error when I ctrl drag on Windows 11 explorer, explorer and flow crashes:
image

@jjw24
Copy link
Member

jjw24 commented Nov 7, 2022

Getting this error when I ctrl drag on Windows 11 explorer, explorer and flow crashes: image

This somehow is no longer an issue after I restarted my Visual Studio.

@jjw24 jjw24 enabled auto-merge November 7, 2022 10:36
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 7, 2022
jjw24
jjw24 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 merged commit 49b9e97 into Flow-Launcher:dev Nov 7, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels

enhancement New feature or request

Projects

Work In Progress
Archived in project

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@onesounds @jjw24 @taooceros