[Program Plugin] Fix UWP icon missing issue #1492
Conversation
| // Just ignore all qualifiers | ||
| // select like logo.[xxx_yyy].png | ||
| // https://learn.microsoft.com/en-us/windows/uwp/app-resources/tailor-resources-lang-scale-contrast | ||
| var selected = files.FirstOrDefault(file => |
There was a problem hiding this comment.
maybe we should prefer
There was a problem hiding this comment.
It's easy but I found some apps don't have a 44x44 logo.
There was a problem hiding this comment.
Try to find closest to 44x44 in the new commit. It seems to work well.
windows security center |
VictoriousRaptor
changed the title
|
@VictoriousRaptor What do you think about just use the icoPath property instead of the callback to let ImageLoader loads the image? I think it's no difference than a specific logo (we can adjust the imageloader a bit to load the actual image but currently icon also works I think). |
Don't quite know how the current callback works. What is the purpose of this change? |
As you have commented. Let the imageloader loads the icon? The current callback handles that separately, but I think it is unnecessary since there is a logo image there. |
I think it's fine. But current callback make the image plated so we need to beware of that. |
|
yeah I am ok with the current change. Let's leave it to the future~ |
4 participants
Program plugin can't get icons for some uwp programs because of complex icon filenames or path finding issue. Tried to fix it.