-
-
Notifications
You must be signed in to change notification settings - Fork 453
Add Node.js environment setup #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
984c490
to
1c4f0ca
Compare
1c4f0ca
to
4e48c3e
Compare
namespace Flow.Launcher.Core.ExternalPlugins.Environments | ||
{ | ||
|
||
internal class JavaScriptEnvironment : TypeScriptEnvironment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL why javascript extends from typescript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly so we don't need to reimplement anything since they both are using same everything. So plugin dev can set their plugin type as JavaScript or Typescript.
order messed up when merging
Changes:
Tested
Close #1157, #1344, #1035