Skip to content

Improve Themes #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 25, 2022
Merged

Improve Themes #1566

merged 20 commits into from
Nov 25, 2022

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 23, 2022 •
edited
Loading

What's the PR

  • Removed Duplicated Color scheme Themes
  • Add New Themes / Adjust old themes
  • Add Theme Share Page Link
  • Adjust Theme Structure
    • Add Bullet, Margin, Selected Glyph Color, Etc
  • Adjust Align when 'Hide Hotkey' setting
  • Add Text Trimming (CharacterEllipsis)
  • Correct the typo / Fix Clock in Preview Area
  • Fix Query Suggestion not display some themes

Test Cases

  • Check Theme Share Page link
  • All Themes works fine with clock and date on/off
  • 'System' themes works with system color scheme (dark mode)
  • Glyph Color should works fine when selected.

@onesounds onesounds marked this pull request as ready for review November 24, 2022 05:22
taooceros
taooceros reviewed Nov 24, 2022
View reviewed changes
Flow.Launcher/Flow.Launcher.csproj Outdated
Comment on lines 50 to 57
<Page Remove="Themes\Bullet Light.xaml" />
<Page Remove="Themes\Circle Light.xaml" />
<Page Remove="Themes\Circle System.xaml" />
<Page Remove="Themes\Cyan Dark.xaml" />
<Page Remove="Themes\Gray.xaml" />
<Page Remove="Themes\Midnight.xaml" />
<Page Remove="Themes\ThemeBuilder\Template.xaml" />
<Page Remove="Themes\Ubuntu.xaml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noooo. csproj always do it like my kid.

@onesounds onesounds self-assigned this Nov 25, 2022
@onesounds onesounds added bug Something isn't working Code Refactor labels Nov 25, 2022
@jjw24 jjw24 added the kind/ui related to UI, icons, themes, etc label Nov 25, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 25, 2022
@jjw24
Copy link
Member

jjw24 commented Nov 25, 2022

@onesounds don't forget to update the Theme customisation doco once 1.10.0 is out if needed.

@jjw24 jjw24 merged commit e7128f9 into Flow-Launcher:dev Nov 25, 2022
@jjw24 jjw24 added the enhancement New feature or request label Nov 25, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taooceros taooceros taooceros left review comments

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels

bug Something isn't working Code Refactor enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@onesounds @jjw24 @taooceros