-
-
Notifications
You must be signed in to change notification settings - Fork 448
[Dev] Refactor AddProgramSource dialog and bugfix #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taooceros
reviewed
Dec 7, 2022
Plugins/Flow.Launcher.Plugin.Program/ViewModels/AddProgramSourceViewModel.cs
Outdated
Show resolved
Hide resolved
taooceros
reviewed
Dec 7, 2022
Plugins/Flow.Launcher.Plugin.Program/ViewModels/AddProgramSourceViewModel.cs
Outdated
Show resolved
Hide resolved
taooceros
reviewed
Dec 7, 2022
Plugins/Flow.Launcher.Plugin.Program/ViewModels/AddProgramSourceViewModel.cs
Outdated
Show resolved
Hide resolved
taooceros
reviewed
Dec 7, 2022
I noticed:
|
taooceros
previously approved these changes
Dec 12, 2022
Sorry I think @jjw24 is right...Let's address those problem |
I fix the first one. The second one may require quite a bit more refactor to fit more mvvm scheme. There's a way to apply style to the item only, but which will overwrite the current style from modernwpf |
jjw24
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactored logic of
AddProgramSource
dialog.For win32 and uwp

ProgramSource
(single programs disabled in results by users), Directory textbox is readonly and the Browse button is hidden. Users shouldn't change its location mannually since it's indexed by plugin, or it may lead to unexpected behavior.Fixed an issue that editing dir of the selected ProgramSource causes the selected item of ProgramSource listview can't be unselected.
Removed unnecessary
LocationConverter
.Tests