Skip to content

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Dec 6, 2022

Changes

  • Refactored logic of AddProgramSource dialog.

  • For win32 and uwp ProgramSource (single programs disabled in results by users), Directory textbox is readonly and the Browse button is hidden. Users shouldn't change its location mannually since it's indexed by plugin, or it may lead to unexpected behavior.
    图片

  • Fixed an issue that editing dir of the selected ProgramSource causes the selected item of ProgramSource listview can't be unselected.

  • Removed unnecessary LocationConverter.

Tests

  • Directory textbox is readonly and the Browse button is hidden for uwp and win32. Custom sources are unaffected.
  • Can Enable/Disable Program Sources.
  • Can Edit Location of Program Sources.
  • Items can be unselected after editing directory.
  • Location and Enabled column in listview are displayed correctly, after editing.

@VictoriousRaptor VictoriousRaptor added bug Something isn't working Code Refactor labels Dec 6, 2022
@VictoriousRaptor VictoriousRaptor self-assigned this Dec 6, 2022
@jjw24
Copy link
Member

jjw24 commented Dec 12, 2022

I noticed:

  1. The Program Source window does not show the path after selecting from the browse button.
  2. Double clicking on the headers 'Name', 'Status' or 'Location' brings up the 'Please select a program source' message window.

taooceros
taooceros previously approved these changes Dec 12, 2022
@taooceros taooceros self-requested a review December 12, 2022 20:34
@taooceros
Copy link
Member

Sorry I think @jjw24 is right...Let's address those problem

@taooceros
Copy link
Member

taooceros commented Dec 12, 2022

I fix the first one. The second one may require quite a bit more refactor to fit more mvvm scheme. There's a way to apply style to the item only, but which will overwrite the current style from modernwpf

@jjw24 jjw24 enabled auto-merge December 12, 2022 22:08
@jjw24 jjw24 merged commit 71a1ca7 into Flow-Launcher:dev Dec 12, 2022
@VictoriousRaptor VictoriousRaptor deleted the FixProgramSource branch December 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Code Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants