-
-
Notifications
You must be signed in to change notification settings - Fork 452
Add "hh:mm:ss tt" to clock formats. #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the pr.
As @onesounds mentioned, there maybe a slight impact on memory, could you please test how much impact there will be. This can be showing a screenshot of before and after using this format.
We will also make it clear to users that this may impact memory. @onesounds what's the best way to do this? Tooltip or warnin text etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments please.
I'll test and then if there are lot memory using, I'll add description part.(aka tooltip) |
I have confirmed that resource usage does not increase in particular. |
Haven't had a chance to take a look, will do so soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hh:mm:ss tt
and HH:mm:ss tt
are not the same.
I know, but tt in |
#1678 Added hh:mm:ss tt to the clock formats to show seconds in the clock.