Improve folder editor experience

[fihorvat]

What's the PR

---

• This feature lets you define an editor for the folder.
• Once we merge this issue can be resolved Open folder in visual studio code #1633

What has been done

---

• Renamed existing setting Editor Path to File Editor Path (only label and command names got renamed so that existing settings still work)
• Introduced a new setting called Folder Editor Path

Test Case

---

• If there is no File Editor Path setting - everything works as before (context menu doesn't shows "Open with editor" command)
• If File Editor Path setting is defined - everything works as before (context menu shows "Open with editor" command)
• If there is no Folder Editor Path setting - everything works as before (context menu doesn't shows "Open with editor" command)
• If Folder Editor Path setting is defined - the context menu shows the editor for the folder

Edit with code example for file

Edit with code example for folder

Explorer plugin settings UI

Before

After

[jjw24]

Hi @fihorvat, thanks for the PR.

Could you please update the description on what you have tested (even if just the intended change with this PR is fine) and also a before and after screenshot would be also nice. This is so the review can be done faster.

[fihorvat]

Hi @jjw24, no problem.
Now it should be okay 😄

[taooceros]

A quick note is that we don't really want crowdin to import translation from our repository. Therefore, these translation you added now may be lost once merged. We may want to copy them to crowdin.

We can trigger upload translation once merged.

Though the quick note is you don't need to add the string to every resource file, which will be very annoying. We have the feature to fallback to english if not present. Those english fallback translation are generated by crowdin due to their xaml setting.

[fihorvat]

@taooceros Ou I didn't know that. It really was annoying trying to translate to every single language and I thought there sure must be a better way 😅
Should I remove all the translations except en?

[taooceros]

@taooceros Ou I didn't know that. It really was annoying trying to translate to every single language and I thought there sure must be a better way 😅 Should I remove all the translations except en?

It's fine to do it like this. It would also be annoying to remove them🤣

[fihorvat]

@jjw24 @taooceros Could anyone take a look at this PR when you find some time?

[taooceros]

@fihorvat I just take a look. Everything looks great to me! There's a small issue (maybe not), that Volume like D:\ won't have this option. Do you think we should add it too?

[fihorvat]

@taooceros I just tried with Volume F:\ and it works great so it should work for all volumes

[taooceros]

Na i mean for F: itself. We have a special Result for volume that display the space usage. I wonder whether we should treat that as a folder as well.

[fihorvat]

@taooceros I didn't even know about that feature, that is so cool 👍
I added the support for that as well and tested that it works 😄

[taooceros]

Thank you so much for the contribution! I have triggered the string upload so hopefully we don't need to manually enter them in!

[shellwhale]

That's a nice feature but it misses the ability to pass command-line arguments. For example code --add allows adding a folder to a currently running instance of vs code (no new vscode window is created).

I had to create a .bat file to wrap my parameters inside. See my answer in #1633