-
-
Notifications
You must be signed in to change notification settings - Fork 452
Always Start in English Layout #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@onesounds @VictoriousRaptor when will users want to turn this option on? |
It is necessary for a person who speaks a language other than English. |
This is why this request occurs. I judged that this function was better than that proposal. (I want to include that function, but that function is harder to implement than I thought. I have to import the ime32.dll to find out. current ime state) This function is difficult to explain to people who only speak English, and it is difficult to test. This is why other programs don't have this function. I believe that this function is very important and worth applying. |
So if I have Korean IME and this option on, I type in search it will start in english but will it also change my language IME to English as well ? For example afterwards I go to website will I be typing English IME of my native IME? |
No. Maybe the tooltip is bit misleading. It hints the IME to use English mode rather than actually changing it. |
This is the difficulty of this function. Suppose a user using English, Korean, and Japanese IME. However, in the case of Korean or JAPANESE IME, there are two LAYOUTs. (LAYOUT is a sub-item of IME.) It is in NATIVE and English. This PR's goal is always use ENGLISH LAYOUT when flow start. The ime that was in use is not changed. Layout is reflected only in the input window of flow. |
|
Thanks for the explanation, let me take this pr for a spin. |
Users can now assure that IME is in English so no issue with typing action keywords. |
I have tried this option and it is not working with Arabic, isn't it supposed to always search in English regardless of the selected language? |
We only tested CJK IME. IME is complex and not well documented. We will take a look. |
@sirito97 How do you type Arabic? I just did some test and seems like Arabic input by Microsoft is not a IME but a keyboard layout, so our current method doesn't work. Sorry about that. |
@VictoriousRaptor Sorry for late reply, I really have no idea what is IME but here's a screenshot of my language input |
it's difficult to explain what IME (Input Method Editor) is in a few words for people who don't use it. If you are curious please google it. May I ask you how do you switch between English and Arabic input? That can tell if you are using an IME. |
@VictoriousRaptor I switch by clicking left alt + shift here's a screenshot too |
It's not an IME then. Sorry we are not able to fix it. |
|
Not working for Russian language
The behaviour is .
Expected behaviour
|
What's the PR
Test Cases