Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Dec 20, 2022

What's the PR

  • Add settings that always start in English when you start flow.
    • If the user is using a Native/English layout, Sometimes the input will start in an unwanted language.
  • It always starts in English, regardless of your language status, so you can avoid typing incorrectly.
  • This setting can be turned on and off; the default is off.

Test Cases

  • Korean / Japanese / Chinese (pinyin)
  • When you turn the flow back on in the native keyboard layout state, typing must begin in English.

@jjw24
Copy link
Member

jjw24 commented Dec 20, 2022

@onesounds @VictoriousRaptor when will users want to turn this option on?

@onesounds
Copy link
Contributor Author

onesounds commented Dec 20, 2022

@onesounds @VictoriousRaptor when will users want to turn this option on?

It is necessary for a person who speaks a language other than English.
Since each language user uses both native language and English at the same time, there is an individual English state for each language IME. This language IME state is difficult to recognize input before it starts. (So it's not until the input progresses that you realize that you're typing in an unintended language.) So we need settings to start English state. Although it can start in the native language, it was judged that it is not general.

@onesounds
Copy link
Contributor Author

#1640

This is why this request occurs. I judged that this function was better than that proposal. (I want to include that function, but that function is harder to implement than I thought. I have to import the ime32.dll to find out. current ime state)

This function is difficult to explain to people who only speak English, and it is difficult to test. This is why other programs don't have this function. I believe that this function is very important and worth applying.

@jjw24
Copy link
Member

jjw24 commented Dec 20, 2022

So if I have Korean IME and this option on, I type in search it will start in english but will it also change my language IME to English as well ? For example afterwards I go to website will I be typing English IME of my native IME?

@jjw24 jjw24 added the enhancement New feature or request label Dec 20, 2022
@jjw24 jjw24 added this to the 1.11.0 milestone Dec 20, 2022
@VictoriousRaptor
Copy link
Contributor

So if I have Korean IME and this option on, I type in search it will start in english but will it also change my language IME to English as well ? For example afterwards I go to website will I be typing English IME of my native IME?

No. Maybe the tooltip is bit misleading. It hints the IME to use English mode rather than actually changing it.

@onesounds
Copy link
Contributor Author

So if I have Korean IME and this option on, I type in search it will start in english but will it also change my language IME to English as well ? For example afterwards I go to website will I be typing English IME of my native IME?

This is the difficulty of this function. Suppose a user using English, Korean, and Japanese IME.
In this case, IME can be switched through win+space. This pr does not change this IME.

However, in the case of Korean or JAPANESE IME, there are two LAYOUTs. (LAYOUT is a sub-item of IME.) It is in NATIVE and English. This PR's goal is always use ENGLISH LAYOUT when flow start.

The ime that was in use is not changed. Layout is reflected only in the input window of flow.
In other words, when I open the flow while writing a document in Chinese, it starts with an English input, and when I close the flow and return to the original process, it is in the Chinese input state.

@onesounds
Copy link
Contributor Author

  • FYI, if you install OS in Korean, only KOREAN IME will be installed. No English IME will be installed unless you add it additionally.

  • all non-English languages IME have two states: English/Native. It is important to understand this part. If you've tried typing Chinese, you'll know that there are two types: English status and Chinese status in Chinese IME.

@jjw24
Copy link
Member

jjw24 commented Dec 20, 2022

Thanks for the explanation, let me take this pr for a spin.

@VictoriousRaptor
Copy link
Contributor

@onesounds @VictoriousRaptor when will users want to turn this option on?

Users can now assure that IME is in English so no issue with typing action keywords.

@VictoriousRaptor VictoriousRaptor merged commit 3ae2ede into Flow-Launcher:dev Dec 20, 2022
@jjw24 jjw24 added bug Something isn't working and removed enhancement New feature or request labels Dec 20, 2022
@jjw24 jjw24 modified the milestones: 1.11.0, 1.10.2 Dec 20, 2022
@jjw24 jjw24 added enhancement New feature or request and removed bug Something isn't working labels Dec 21, 2022
@jjw24 jjw24 modified the milestones: 1.10.2, 1.11.0 Dec 21, 2022
@elkhaligy
Copy link

I have tried this option and it is not working with Arabic, isn't it supposed to always search in English regardless of the selected language?

@VictoriousRaptor
Copy link
Contributor

VictoriousRaptor commented Jan 23, 2023

I have tried this option and it is not working with Arabic, isn't it supposed to always search in English regardless of the selected language?

We only tested CJK IME. IME is complex and not well documented. We will take a look.

@VictoriousRaptor
Copy link
Contributor

@sirito97 How do you type Arabic? I just did some test and seems like Arabic input by Microsoft is not a IME but a keyboard layout, so our current method doesn't work. Sorry about that.

@elkhaligy
Copy link

@sirito97 How do you type Arabic? I just did some test and seems like Arabic input by Microsoft is not a IME but a keyboard layout, so our current method doesn't work. Sorry about that.

@VictoriousRaptor Sorry for late reply, I really have no idea what is IME but here's a screenshot of my language input
Screenshot_20230124_072347

@VictoriousRaptor
Copy link
Contributor

@sirito97 How do you type Arabic? I just did some test and seems like Arabic input by Microsoft is not a IME but a keyboard layout, so our current method doesn't work. Sorry about that.

@VictoriousRaptor Sorry for late reply, I really have no idea what is IME but here's a screenshot of my language input Screenshot_20230124_072347

it's difficult to explain what IME (Input Method Editor) is in a few words for people who don't use it. If you are curious please google it. May I ask you how do you switch between English and Arabic input? That can tell if you are using an IME.

@elkhaligy
Copy link

@VictoriousRaptor I switch by clicking left alt + shift here's a screenshot too
image

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor I switch by clicking left alt + shift here's a screenshot too image

It's not an IME then. Sorry we are not able to fix it.

@elkhaligy
Copy link

@VictoriousRaptor I switch by clicking left alt + shift here's a screenshot too image

It's not an IME then. Sorry we are not able to fix it.

It's ok, I managed to fix it by ticking this option
IMG-20230123-WA0025.jpg

@Sing303
Copy link

Sing303 commented May 2, 2023

Not working for Russian language

  1. Turned on "English Mode"
  2. Switching to Russian language
  3. Opened Flow Launcher.

The behaviour is .

  • Language is still Russian

Expected behaviour

  • Regardless of the current layout, English characters are printed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants